-
Notifications
You must be signed in to change notification settings - Fork 19
Comparing changes
Open a pull request
base repository: vmware-archive/transport-go
base: v1.3.2
head repository: vmware-archive/transport-go
compare: main
- 12 commits
- 67 files changed
- 2 contributors
Commits on Nov 2, 2021
-
new: Add
SendBroadcastMessage()
bus method (#41)This PR implements a new method to the event bus API that will hopefully reduce confusion around use of the basic event bus API methods around broadcasting scenarios. Details can be tracked in this GitHub issue: #40 Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 4cd6850 - Browse repository at this point
Copy the full SHA 4cd6850View commit details
Commits on Dec 1, 2021
-
new: Add method to Message to cast to a given type (#43)
Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 27e75b6 - Browse repository at this point
Copy the full SHA 27e75b6View commit details -
[fix] Add missing STOMP over TCP option for Plank (#42)
* [fix] Add missing STOMP over TCP option for Plank Signed-off-by: Josh Kim <kjosh@vmware.com> * [fix] incorrect outbound send call for incoming msg Signed-off-by: Josh Kim <kjosh@vmware.com> * (new) broker_sample example talking to another Plank via TCP Signed-off-by: Josh Kim <kjosh@vmware.com> * fix: handle server start errors properly Signed-off-by: Josh Kim <kjosh@vmware.com> * test: increase test coverage Signed-off-by: Josh Kim <kjosh@vmware.com> * change: simplify sample code using CastPayloadToType Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 553eea5 - Browse repository at this point
Copy the full SHA 553eea5View commit details
Commits on Dec 2, 2021
-
change: use better StockTickerService API provider (#28)
* change: use better StockTickerService API provider Signed-off-by: Josh Kim <kjosh@vmware.com> * Include closePrice in return data structure Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 3c1a8f0 - Browse repository at this point
Copy the full SHA 3c1a8f0View commit details
Commits on Dec 8, 2021
-
Fix UUID equality check bug (#45)
* format: gofmt on all source files Signed-off-by: Josh Kim <kjosh@vmware.com> * fix: UUID comparison logic bug UUID is used throughout the entire codebase of Transport and is especially important in filtering messages based on their destination. While implementing basic WASM bridge for the bus I realized that UUID comparison was failing, i.e. returning true for the equality check between two dififerent UUID instances. Turns out the use of .ID() method on the UUID object only returns the first 4 bytes of the underlying 16-byte slice. This means as long as the first 8 hexadecimal characters matched between two UUID instances, they would come out as equal, and it would therefore mean a significantly higher chance of UUID collision.. The fix introduced in this PR is to use the string comparison of the full UUID in places where .ID() was used. Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 6d9ecb6 - Browse repository at this point
Copy the full SHA 6d9ecb6View commit details
Commits on Feb 17, 2022
-
Disable boot image by default (#48)
Consuming ~700kB just for the purpose of showing a splash image is not a good idea for a library, hence disabling it by default and making it an opt-in feature. Use `--tags boot_img` in `go build` or `go run` to opt in. Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 979915f - Browse repository at this point
Copy the full SHA 979915fView commit details -
test: More server pkg unit tests (#44)
Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 77c3333 - Browse repository at this point
Copy the full SHA 77c3333View commit details
Commits on Feb 20, 2022
-
Fix current map write bug in rest bridge config (#49)
Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 5ca9bcc - Browse repository at this point
Copy the full SHA 5ca9bccView commit details
Commits on Mar 2, 2022
-
Improve response payload casting operation (#50)
`model.Message` struct has a method `CastPayloadToType` used to conveniently cast `Message.Payload.(Response).Payload` into the type of the provided argument. The current implementation had a few gaps that made the method only viaible in situations where `Message.Payload` were yet to be unmarshalled (e.g. `interface{} | []byte`). This PR also fixes a bug in rest_service.go where `RestServiceRequest.ResponseType` was never customizable, leading to the response body to be always treated like a JSON-decodable structure. This would cause HTTP calls whose response type is not of JSON to throw errors. By only deserializing the body for which the request header `Content-Type` is of JSON type and passing others as raw byte slices, the RestService callers can handle response payloads of arbitrary MIME types. Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 9ad7c33 - Browse repository at this point
Copy the full SHA 9ad7c33View commit details
Commits on Feb 6, 2023
-
Fix memory leak bug in StockTickerService Plank sample service (#53)
Signed-off-by: Josh Kim <jsk9260@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 51f2947 - Browse repository at this point
Copy the full SHA 51f2947View commit details
Commits on Mar 30, 2023
-
Fix vulnerabilities by bumping dependency versions in go.mod (#54)
Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for f5a624b - Browse repository at this point
Copy the full SHA f5a624bView commit details -
Bump golang.org/x/net to fix remaining lib-induced vulnerabilities (#55)
Signed-off-by: Josh Kim <kjosh@vmware.com>
Configuration menu - View commit details
-
Copy full SHA for 32bcedb - Browse repository at this point
Copy the full SHA 32bcedbView commit details
There are no files selected for viewing