Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

(impact: high) Cannot add icon to action button #382

Open
2 tasks done
irahov opened this issue Aug 30, 2021 · 0 comments
Open
2 tasks done

(impact: high) Cannot add icon to action button #382

irahov opened this issue Aug 30, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@irahov
Copy link
Contributor

irahov commented Aug 30, 2021

Prerequisites

[Check these off before submitting an issue].

  • Are you running the latest version? OR Are you submitting a bug for a prior version?
  • Did you perform a basic issue search?

For more information, see the CONTRIBUTING guide.

Description

The BaseActionItem contains icon?: string; property but it is not taken into account, i.e. when a value is assigned to the property the UI does not render the corresponding icon
"@vcd/ui-components": "2.0.0",

Versions

  1. Package version (run npm version)
    core (master) $ npm version
    {
    'vcd-ui-core': '9.0.0',
    npm: '6.14.4',
    ares: '1.16.0',
    brotli: '1.0.7',
    cldr: '36.0',
    http_parser: '2.9.3',
    icu: '65.1',
    llhttp: '2.0.4',
    modules: '72',
    napi: '5',
    nghttp2: '1.40.0',
    node: '12.16.3',
    openssl: '1.1.1g',
    tz: '2019c',
    unicode: '12.1',
    uv: '1.34.2',
    v8: '7.8.279.23-node.35',
    zlib: '1.2.11'
    }

  2. Node Version (run node -v)
    core (master) $ node -v
    v12.16.3

  3. OS Version

  4. Browser Version

Screenshot 2021-08-30 at 15 50 16

@irahov irahov added the bug Something isn't working label Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant