add fractional support

Signed-off-by: iTrooz <hey@itrooz.fr>

Author: iTrooz

pkg/cmd/util/flag/duration.go

@@ -31,28 +31,33 @@ var unitMap = map[string]uint64{
 	"yr": uint64(365 * 24 * time.Hour),
 }
 
-// ParseDuration parses strings like "2d5h10m"
+// ParseDuration parses strings like "2d5h10.5m"
+// it does not support negative durations.
 func ParseDuration(s string) (Duration, error) {
 	s = strings.TrimSpace(s)
 	if s == "" {
 		return Duration{Duration: 0}, nil
 	}
 
-	var total uint64
+	var total float64
 	i := 0
 	n := len(s)
 
 	for i < n {
-		// Get number
+		// Get number (including decimal point)
 		j := i
-		for j < n && unicode.IsDigit(rune(s[j])) {
+		hasDot := false
+		for j < n && (unicode.IsDigit(rune(s[j])) || (s[j] == '.' && !hasDot)) {
+			if s[j] == '.' {
+				hasDot = true
+			}
 			j++
 		}
 		if j == i {
 			return Duration{}, fmt.Errorf("expected number at pos %d", i)
 		}
 		numStr := s[i:j]
-		num, err := strconv.ParseUint(numStr, 10, 64)
+		num, err := strconv.ParseFloat(numStr, 64)
 		if err != nil {
 			return Duration{}, err
 		}
@@ -73,15 +78,15 @@ func ParseDuration(s string) (Duration, error) {
 			return Duration{}, fmt.Errorf("unknown unit %q", unit)
 		}
 		// Add to total
-		total += num * val
+		total += num * float64(val)
 
 		i = k
 		for i < n && s[i] == ' ' {
 			i++
 		}
 	}
 
-	// Convert integer seconds into time.Duration
+	// Convert to time.Duration (nanoseconds)
 	return Duration{Duration: time.Duration(total)}, nil
 }
 

pkg/cmd/util/flag/duration_test.go

@@ -104,6 +104,38 @@ func TestParseDuration(t *testing.T) {
 			wantErr:  false,
 		},
 
+		// Fractional values
+		{
+			name:     "basic fraction",
+			input:    "5.5s",
+			expected: time.Duration(5.5 * float64(time.Second)),
+			wantErr:  false,
+		},
+		{
+			name:     "fraction with no decimal part",
+			input:    "5.s",
+			expected: time.Duration(5 * float64(time.Second)),
+			wantErr:  false,
+		},
+		{
+			name:     "fractional with multiple decimals",
+			input:    "1.25h30.5m",
+			expected: time.Duration(1.25*float64(time.Hour) + 30.5*float64(time.Minute)),
+			wantErr:  false,
+		},
+		{
+			name:     "fractional zero",
+			input:    "0.0s",
+			expected: 0,
+			wantErr:  false,
+		},
+		{
+			name:     "mixed integer and fractional",
+			input:    "2h1.5m30s",
+			expected: 2*time.Hour + time.Duration(1.5*float64(time.Minute)) + 30*time.Second,
+			wantErr:  false,
+		},
+
 		// Error cases
 		{
 			name:     "invalid character at start",
@@ -142,8 +174,8 @@ func TestParseDuration(t *testing.T) {
 			wantErr:  true,
 		},
 		{
-			name:     "decimal number",
-			input:    "5.5s",
+			name:     "multiple decimal points",
+			input:    "5.5.5s",
 			expected: 0,
 			wantErr:  true,
 		},