Issue #8772 ensure pv removed #8777
Open
+124
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Zimmermann <[email protected]>
Signed-off-by: Roger Zimmermann <[email protected]>
Signed-off-by: Roger Zimmermann <[email protected]>
Signed-off-by: Roger Zimmermann <[email protected]> Signed-off-by: Roger Zimmermann <[email protected]>
ix-rzi
force-pushed
the
Issue-#8772-ensure-pv-removed
branch
from
50f5141 to
081eb46
Compare
|
Don't think there is something to update in the docs, but I might be mistaken. |
kaovilai
approved these changes
Mar 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8777 +/- ##
==========================================
+ Coverage 59.53% 59.55% +0.01%
==========================================
Files 371 371
Lines 40196 40258 +62
==========================================
+ Hits 23932 23975 +43
- Misses 14767 14782 +15
- Partials 1497 1501 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lyndon-Li
reviewed
Mar 12, 2025
| @@ -74,6 +74,10 @@ func DeletePVAndPVCIfAny(ctx context.Context, client corev1client.CoreV1Interfac | |||
| if err := EnsureDeletePVC(ctx, client, pvcName, pvcNamespace, ensureTimeout); err != nil { | |||
| log.Warnf("failed to delete pvc %s/%s with err %v", pvcNamespace, pvcName, err) | |||
| } | |||
|
|
|||
| if err := EnsureDeletePV(ctx, client, pvcObj.Spec.VolumeName, ensureTimeout); err != nil { | |||
| log.Warnf("pv %s was not removed with err %v", &pvcObj.Spec.VolumeName, err) | |||
There was a problem hiding this comment.
Why do we pass a pointer (of pvcObj.Spec.VolumeName) here for %s?
There was a problem hiding this comment.
good catch..
Suggested change
| log.Warnf("pv %s was not removed with err %v", &pvcObj.Spec.VolumeName, err) | |
| log.Warnf("pv %s was not removed with err %v", pvcObj.Spec.VolumeName, err) |
| @@ -157,6 +161,37 @@ func EnsureDeletePVC(ctx context.Context, pvcGetter corev1client.CoreV1Interface | |||
| return nil | |||
| } | |||
|
|
|||
| // EnsureDeletePV ensures a PV has been deleted. This function is supposed to be called after EnsureDeletePVC | |||
| // If timeout is 0, it doesn't wait and return nil | |||
| func EnsureDeletePV(ctx context.Context, pvGetter corev1client.CoreV1Interface, pvName string, timeout time.Duration) error { | |||
There was a problem hiding this comment.
It's better to have the name as EnsurePVDeleted since we don't make any deletion as same as other EnsureDelete* functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
The node-agent does not wait for the PV to be removed on the cluster before deleting the VolumeSnapshot. The change
lets the node-agent wait for the PV to be removed from the cluster before removing the VS.
Does your change fix a particular issue?
Fixes #8772
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.