Skip to content

Commit f7a74cc

Browse files
davidbrochartpre-commit-ci[bot]martinRenou
authored
Simplify some code (#1329)
* Use partial * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove unneeded inner_cell_generator function * Change comments a bit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: martinRenou <[email protected]>
1 parent a2453b3 commit f7a74cc

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

voila/notebook_renderer.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import os
1212
import sys
1313
import traceback
14+
from functools import partial
1415
from copy import deepcopy
1516
from typing import Generator, List, Tuple, Union
1617

@@ -154,23 +155,21 @@ def generate_content_generator(
154155
kernel_id: Union[str, None] = None,
155156
kernel_future=None,
156157
) -> Generator:
157-
async def inner_kernel_start(nb):
158-
return await self._jinja_kernel_start(nb, kernel_id, kernel_future)
159-
160-
def inner_cell_generator(nb, kernel_id):
161-
return self._jinja_cell_generator(nb, kernel_id)
158+
inner_kernel_start = partial(
159+
self._jinja_kernel_start, kernel_id=kernel_id, kernel_future=kernel_future
160+
)
162161

163-
# These functions allow the start of a kernel and execution of the
164-
# notebook after (parts of) the template has been rendered and send
162+
# kernel_start and cell_generator allow starting the kernel and executing the
163+
# notebook after (parts of) the template has been rendered and sent
165164
# to the client to allow progressive rendering.
166165
# Template should first call kernel_start, and then decide to use
167-
# notebook_executer cell_generator to implement progressive cell rendering
166+
# notebook_executer cell_generator to implement progressive cell rendering.
168167

169168
extra_context = {
170169
"frontend": "voila",
171170
"main_js": "voila.js",
172171
"kernel_start": inner_kernel_start,
173-
"cell_generator": inner_cell_generator,
172+
"cell_generator": self._jinja_cell_generator,
174173
"notebook_execute": self._jinja_notebook_execute,
175174
}
176175
# render notebook in snippets, then return an iterator so we can flush

0 commit comments

Comments
 (0)