Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The WorkLoadSupport feature gate was implemented in an incorrect section of the code. #4091

Open
yuyue9284 opened this issue Mar 13, 2025 · 0 comments · May be fixed by #4092
Open

The WorkLoadSupport feature gate was implemented in an incorrect section of the code. #4091

yuyue9284 opened this issue Mar 13, 2025 · 0 comments · May be fixed by #4092
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@yuyue9284
Copy link

yuyue9284 commented Mar 13, 2025

Description

WorkLoadSupport is used here to control volcano job handling. But VolcanoJobSupport is not used in the code base.

if utilfeature.DefaultFeatureGate.Enabled(features.WorkLoadSupport) {
cc.jobInformer = factory.Batch().V1alpha1().Jobs()
cc.jobInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: cc.addJob,
UpdateFunc: cc.updateJob,
DeleteFunc: cc.deleteJob,
})
cc.jobLister = cc.jobInformer.Lister()
cc.jobSynced = cc.jobInformer.Informer().HasSynced
}

Steps to reproduce the issue

  1. Disable WorkLoadSupport
  2. Submit volcano job

Describe the results you received and expected

Disable WorkLoadSupport should not disable volcano job handling.

What version of Volcano are you using?

master

Any other relevant information

No response

@yuyue9284 yuyue9284 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 13, 2025
@yuyue9284 yuyue9284 changed the title Feature gate WorkLoadSupport added to wrong part of the code. The WorkLoadSupport feature gate was implemented in an incorrect section of the code. Mar 13, 2025
@yuyue9284 yuyue9284 linked a pull request Mar 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant