Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] update feature flag for job support #4092

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

yuyue9284
Copy link

@yuyue9284 yuyue9284 commented Mar 13, 2025

What type of PR is this?

Bugfix

What this PR does / why we need it:

Fix feature gate usage for VolcanoJobSupport

Which issue(s) this PR fixes:

Fixes #4091

Special notes for your reviewer:

Does this PR introduce a user-facing change?

User use WorkLoadSupport to disable volcano job functionality might change to VolcanoJobSupport


@volcano-sh-bot
Copy link
Contributor

Welcome @yuyue9284!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2025
@Monokaix
Copy link
Member

/approve
/ok-to-test
Thanks!

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 14, 2025
@Monokaix
Copy link
Member

Please squash to one commit.

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2025
Signed-off-by: Yue Yu <yuyue9284@outlook.com>
@JesseStutler
Copy link
Member

Good catch!
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
@volcano-sh-bot volcano-sh-bot merged commit 8d1658a into volcano-sh:master Mar 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The WorkLoadSupport feature gate was implemented in an incorrect section of the code.
4 participants