Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-node testing in beaker workflow #51

Closed
alexjfisher opened this issue Feb 10, 2024 · 4 comments · Fixed by #53
Closed

Support multi-node testing in beaker workflow #51

alexjfisher opened this issue Feb 10, 2024 · 4 comments · Fixed by #53

Comments

@alexjfisher
Copy link
Member

Modules such openvpn and spiped currently can't be modulesynced to use the shared actions as they require beaker setfiles with more than one host. eg https://github.com/voxpupuli/puppet-openvpn/blob/7ce40c3baa99b77880f8b5a9062bd36cc5557ad0/.github/workflows/ci.yml#L69-L85

I think the first step will be to decide what a new command line option to metadata2gha would look like and then implement that change over in https://github.com/voxpupuli/puppet_metadata

eg. maybe something like the following
--multi-node-roles server,ma:client,a

would produce setfile values of the form
ubuntu1804-64server.ma{hostname=server}-ubuntu1804-64client.a{hostname=client}

I'm setting the hostname and the 'arbitrary-role' to be the same thing. Maybe that's too limited, but maybe if it's ok for 90% of the use-cases, then that's ok. Dunno.

@ekohl
Copy link
Member

ekohl commented Feb 10, 2024

#46 is an effort that @jhoblitt already started that looks a lot like what you're suggesting.

@jhoblitt
Copy link
Member

#46 is waiting on review.

@ekohl
Copy link
Member

ekohl commented Feb 26, 2025

Should this be closed since #53 was merged?

@bastelfreak
Copy link
Member

yes

@ekohl ekohl linked a pull request Feb 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants