Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 broken by hiera datadir support #89

Closed
zilchms opened this issue Jan 30, 2024 · 3 comments · Fixed by #90
Closed

Release 1.2.0 broken by hiera datadir support #89

zilchms opened this issue Jan 30, 2024 · 3 comments · Fixed by #90

Comments

@zilchms
Copy link
Contributor

zilchms commented Jan 30, 2024

Seems we have accidentally broken something by trying to support hiera datadir. See #86
@bastelfreak @alexjfisher @h0tw1r3
Tagging you here to keep this all in one place and keep track.

@h0tw1r3
Copy link
Contributor

h0tw1r3 commented Jan 30, 2024

I have more branches in the queue to modernize how ghostbuster works. Unfortunately it's very opinionated about the path names it processes (ie. must be prefixed with `./), and the various tests can parse the filenames in different ways (classes for sure are different).

@alexjfisher it's not immediately apparent from the output why this is happening.

Can you provide the full command you're running, and the general directory layout of the thing being ghost busted?

@alexjfisher
Copy link
Member

It's the puppet-lint plugin that's broken if you don't have HIERA_YAML_PATH set and the default /etc/puppetlabs/code/hiera.yaml doesn't exist either.
I wasn't explicitly trying to do anything with puppet-ghostbuster, (but it is in my control-repo Gemfile, so my puppet-lint jobs started to fail). I guess previously, the check method returned early here.

@alexjfisher
Copy link
Member

@h0tw1r3 I've opened a one line PR on a random module to demonstrate voxpupuli/puppet-extlib#219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants