Skip to content

jenkins present.pp does not fix single-quotes for xml 1.1 #999

Open
@jnathlich

Description

@jnathlich

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 2019.8
  • Ruby:
  • Distribution:
  • Module version: 2.0

How to reproduce (e.g Puppet code you use)

use jenkins module to create a job with a config.xml that has this first line...
<?xml version='1.1' encoding='UTF-8'?>

What are you seeing

It runs update-job on every puppet run, as the code is looking for '1.0' in the string above.
line 47 in present.pp
# Jenkins likes to change single quotes to double quotes
$a = regsubst($config, 'version=\'1.0\' encoding=\'UTF-8\'',
'version="1.0" encoding="UTF-8"')

What behaviour did you expect instead

My regex sucks, but it should look for version = x.y, where x and y are single numerals.

Output log

Any additional information you'd like to impart

Not a huge deal. Can fix input files to avoid this and make it work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions