redis::instance: do not exec cp if source and destination are equal

Author: trefzer

manifests/instance.pp

@@ -355,8 +355,6 @@
     if $title != 'default' {
       $real_service_ensure = $service_ensure == 'running'
       $real_service_enable = $service_enable
-
-      Exec["cp -p ${redis_file_name_orig} ${redis_file_name}"] ~> Service["${service_name}.service"]
     } else {
       $real_service_ensure = undef
       $real_service_enable = undef
@@ -496,9 +494,15 @@
     ),
   }
 
-  exec { "cp -p ${redis_file_name_orig} ${redis_file_name}":
-    path        => '/usr/bin:/bin',
-    subscribe   => File[$redis_file_name_orig],
-    refreshonly => true,
+  if $redis_file_name_orig != $redis_file_name {
+    exec { "cp -p ${redis_file_name_orig} ${redis_file_name}":
+      path        => '/usr/bin:/bin',
+      subscribe   => File[$redis_file_name_orig],
+      refreshonly => true,
+    }
+
+    if $title != 'default' and $manage_service_file {
+      Exec["cp -p ${redis_file_name_orig} ${redis_file_name}"] ~> Service["${service_name}.service"]
+    }
   }
 }