dns_stub_listener cannot be set to "no"

[DaAwesomeP]

Hello,

When setting dns_stub_listener to false, it does not cause DNSStubListener to be set to no. This is an issue for systems where DNSStubListener is yes by default.

I believe this is because the code below is checking if $dns_stub_listener is a String, but it should maybe be checking $_dns_stub_listener instead?

puppet-systemd/manifests/resolved.pp

Line 61 in 71f8d19

Optional[Variant[Boolean,Enum['udp', 'tcp','absent']]] $dns_stub_listener = $systemd::dns_stub_listener,

puppet-systemd/manifests/resolved.pp

Lines 236 to 251 in 71f8d19

	$_dns_stub_listener = $dns_stub_listener ? {
	true => 'yes',
	false => 'no',
	default => $dns_stub_listener,
	}
	if $dns_stub_listener =~ String[1] {
	ini_setting { 'dns_stub_listener':
	ensure => stdlib::ensure($dns_stub_listener != 'absent'),
	value => $_dns_stub_listener,
	setting => 'DNSStubListener',
	section => 'Resolve',
	path => '/etc/systemd/resolved.conf',
	notify => Service['systemd-resolved'],
	}
	}

[ekohl]

I think you're right