You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: (@vue/apollo-option) memory leak in wrapped ssrRender
Fixes#1550
Two leaks were fixed:
1) Prevents repeatedly wrapping `ssrRender` by checking if it's already
been wrapped. Added a `__IS_VUE_APOLLO_WRAPPED` boolean to track this.
I verified that this was actually happening by throwing an error if
it was already wrapped, and I observed the error.
2) `this.$options.ssrRender` doesn't always exist, but this.$apollo
does. When the new wrapped `ssrRender` was called, it would throw,
which prevented the `destroy.call(this)` line from running. The fix
here was to not create a wrapped `ssrRender` if there isn't an original
one.
0 commit comments