ci: correct PR number retrieval to fix size-report action #11223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f9587f.
|
@jh-leong I couldn't reproduce what you say. This looks like could be the solution The artifacts idea is not good either: it can be tampered in the origin. |
|
This is another approach that we could attempt, imo even better because that way, in runs logs, they're grouped and it's easier to know the general flow of what's happening. |
|
/cc @sxzz |
sxzz
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the size report action has not been working recently.
The failure is due to the action using
github.event.workflow_run.pull_requests[0].numberto read the PR number. However, according to GitHub's security policy (ref: https://github.com/orgs/community/discussions/25220), this approach does not work for PRs from forked repositories aspull_requestscan be empty.To resolve this, I have reverted the method of retrieving the PR number to the previous implementation using artifact.