Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.7.7] v-dialog origin prop not working #20919

Open
johuhype opened this issue Jan 24, 2025 · 2 comments
Open

[Bug Report][3.7.7] v-dialog origin prop not working #20919

johuhype opened this issue Jan 24, 2025 · 2 comments
Labels
C: VDialog has workaround T: bug Functionality that does not work as intended/expected

Comments

@johuhype
Copy link

johuhype commented Jan 24, 2025

Environment

Vuetify Version: 3.7.7
Last working version: 2.7.2
Vue Version: 3.5.13
Browsers: Chrome 132.0.0.0
OS: Windows

Steps to reproduce

Specify a origin differing from "center center".
It does not get applied when opening the dialog.

Plus: You are referring to https://developer.mozilla.org/en-US/docs/Web/CSS/transform-origin for possible values. But according to the Type, eg. '20% 20%' would not be allowed.

Setting an origin other than 'center center' and using percentage values for it is working in Vuetify 2.

Expected Behavior

Respect the given origin for the opening animation.

Actual Behavior

Always uses the centered opening.

Reproduction Link

https://play.vuetifyjs.com/#...

@J-Sek
Copy link
Contributor

J-Sek commented Jan 24, 2025

I was able to track origin prop usage deep in locationStrategies.ts and it seems the type declaration is correct - it can only be Anchor, 'auto' or 'overlap'. Link in the API docs description is confusing and should be removed.

Apart from this, origin on VDialog is not even parsed unless you set location-strategy="connected" but even this does not seem to have any effect. It might be one of those API leaks that expose unnecessary props not actually intended for use on this level.

@J-Sek
Copy link
Contributor

J-Sek commented Jan 24, 2025

Workaround would be to use location-strategy="connected" and point to a <div> target placed in the corner of the page.

@J-Sek J-Sek added T: bug Functionality that does not work as intended/expected C: VDialog has workaround labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDialog has workaround T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

2 participants