Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import DefaultAdapter is Plugin #109

Closed
ghost opened this issue Jun 19, 2019 · 5 comments · Fixed by #110
Closed

Import DefaultAdapter is Plugin #109

ghost opened this issue Jun 19, 2019 · 5 comments · Fixed by #110

Comments

@ghost
Copy link

ghost commented Jun 19, 2019

If we import default adapter type by

import DefaultAdapter from '@vuex-orm/plugin-graphql';

VSCode thinks it is VuexORMGraphQL from dist/types/vuex-orm-graphql.d.ts

Can we change typings property in package.json to dist/types/index.d.ts and move VuexORMGraphQL declaration inside?

@phortx
Copy link
Collaborator

phortx commented Jun 19, 2019

VSCode is right, it should be

import { DefaultAdapter } from '@vuex-orm/plugin-graphql';

;)

@ghost
Copy link
Author

ghost commented Jun 19, 2019

@phortx,

DeepinScreenshot_select-area_20190619124911

with default "typings": "dist/types/vuex-orm-graphql.d.ts" it is not working correct.

If i change it to "typings": "dist/types/index.d.ts", all works correct even plugin :)

@phortx
Copy link
Collaborator

phortx commented Jun 19, 2019

Alright, that sounds plausible. Could you create a MR? :)

@ghost
Copy link
Author

ghost commented Jun 19, 2019

PR #110

@phortx
Copy link
Collaborator

phortx commented Jun 19, 2019

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant