Implement ClientIdentifier DHCP option

Techassi · Techassi · commit bfcd917e050a · 2023-03-17T22:12:02.000+01:00
diff --git a/crates/lib-dhcp/src/types/option/data.rs b/crates/lib-dhcp/src/types/option/data.rs
@@ -225,7 +225,7 @@ impl Writeable for OptionData {
             OptionData::RenewalT1Time(time) => time.write::<E>(buf)?,
             OptionData::RebindingT2Time(time) => time.write::<E>(buf)?,
             OptionData::ClassIdentifier(_) => todo!(),
-            OptionData::ClientIdentifier(_) => todo!(),
+            OptionData::ClientIdentifier(c) => c.write::<E>(buf)?,
         };
 
         Ok(n)
@@ -413,7 +413,7 @@ impl OptionData {
             OptionData::RenewalT1Time(_) => 4,
             OptionData::RebindingT2Time(_) => 4,
             OptionData::ClassIdentifier(_) => todo!(),
-            OptionData::ClientIdentifier(_) => todo!(),
+            OptionData::ClientIdentifier(c) => c.len() as u8,
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ impl Writeable for OptionData {`
`225`	`225`	`OptionData::RenewalT1Time(time) => time.write::<E>(buf)?,`
`226`	`226`	`OptionData::RebindingT2Time(time) => time.write::<E>(buf)?,`
`227`	`227`	`OptionData::ClassIdentifier(_) => todo!(),`
`228`		`- OptionData::ClientIdentifier(_) => todo!(),`
	`228`	`+ OptionData::ClientIdentifier(c) => c.write::<E>(buf)?,`
`229`	`229`	`};`
`230`	`230`
`231`	`231`	`Ok(n)`
`@@ -413,7 +413,7 @@ impl OptionData {`
`413`	`413`	`OptionData::RenewalT1Time(_) => 4,`
`414`	`414`	`OptionData::RebindingT2Time(_) => 4,`
`415`	`415`	`OptionData::ClassIdentifier(_) => todo!(),`
`416`		`- OptionData::ClientIdentifier(_) => todo!(),`
	`416`	`+ OptionData::ClientIdentifier(c) => c.len() as u8,`
`417`	`417`	`}`
`418`	`418`	`}`
`419`	`419`	`}`