From 307cc59350e2f9cbef07a702d0d8d9e0700bff05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Wed, 9 Jun 2021 19:53:43 +1000 Subject: [PATCH 1/7] Gracefully handle documents that are not fully active --- index.html | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/index.html b/index.html index 5a70bfc..aa565a3 100644 --- a/index.html +++ b/index.html @@ -594,7 +594,18 @@

  1. Let |watchTasks:Set| be [=this=]'s - {{Geolocation/[[watchTasks]]}}. + {{Geolocation/[[watchTasks]]}}. +
    2. +
  2. + If the [=current settings object=]'s [=associated `Document`=] is not [=fully active=]: +
      +
    1. + [=list/Empty=] |watchTasks|. +
      2. +
    2. + Return [=implementation-defined=] {{long}}. +
      3. +
  3. Acquire a watch id.
      From f9a9ca761ed50eb37dbc54710d9364c22ddd203b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Wed, 9 Jun 2021 19:55:00 +1000 Subject: [PATCH 2/7] tidy --- index.html | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/index.html b/index.html index aa565a3..22edb8a 100644 --- a/index.html +++ b/index.html @@ -594,16 +594,14 @@

      1. Let |watchTasks:Set| be [=this=]'s - {{Geolocation/[[watchTasks]]}}. -
        2. -
      2. - If the [=current settings object=]'s [=associated `Document`=] is not [=fully active=]: + {{Geolocation/[[watchTasks]]}}. +
        3. +
      3. If the [=current settings object=]'s [=associated `Document`=] is + not [=fully active=]:
          -
        1. - [=list/Empty=] |watchTasks|. +
        2. [=list/Empty=] |watchTasks|.
          3. -
        3. - Return [=implementation-defined=] {{long}}. +
        4. Return [=implementation-defined=] {{long}}.
        4. From 84217ba251989c9c44dad613d9168d3a09085fdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Thu, 10 Jun 2021 22:29:38 +1000 Subject: [PATCH 3/7] fixup --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index 22edb8a..374763e 100644 --- a/index.html +++ b/index.html @@ -601,7 +601,7 @@

        1. [=list/Empty=] |watchTasks|.
          2. -
        2. Return [=implementation-defined=] {{long}}. +
        3. Return an [=implementation-defined=] {{long}}.
        From f38c6807543400531ee2257b3c93629ba4110b5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Wed, 9 Jun 2021 19:53:43 +1000 Subject: [PATCH 4/7] Gracefully handle documents that are not fully active --- index.html | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/index.html b/index.html index f4efeeb..453e97e 100644 --- a/index.html +++ b/index.html @@ -592,7 +592,18 @@

        1. Let |watchTasks:Set| be [=this=]'s - {{Geolocation/[[watchTasks]]}}. + {{Geolocation/[[watchTasks]]}}. +
          2. +
        2. + If the [=current settings object=]'s [=associated `Document`=] is not [=fully active=]: +
            +
          1. + [=list/Empty=] |watchTasks|. +
            2. +
          2. + Return [=implementation-defined=] {{long}}. +
            3. +
        3. If the [=current settings object=]'s [=associated `Document`=] is not [=fully active=]: From be3c046d9089caa602c8aa47861c797979c2b5df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Fri, 9 Jul 2021 11:07:00 +1000 Subject: [PATCH 5/7] Integrate better with visibility --- index.html | 46 +++++++++++++++++++++++++++++++++------------- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/index.html b/index.html index 453e97e..f5949d4 100644 --- a/index.html +++ b/index.html @@ -118,6 +118,9 @@

          has received the following changes:

            +
          • Added handling for when documents are not [=Document/fully + active=]. +
          • Added the [=geolocation task source=], which handles dispatching position updates and errors.
            • @@ -591,6 +594,10 @@

            optionally (and only if |repeats| is true) a |previousId:long|.

              +
            1. If the [=current settings object=]'s [=associated `Document`=] is + not [=Document/fully active=], return an [=implementation-defined=] + {{long}}. +
            2. Let |watchTasks:Set| be [=this=]'s {{Geolocation/[[watchTasks]]}}.
              3. @@ -605,15 +612,6 @@

            -
          • If the [=current settings object=]'s [=associated `Document`=] is - not [=fully active=]: -
              -
            1. [=list/Empty=] |watchTasks|. -
              2. -
            2. Return an [=implementation-defined=] {{long}}. -
              3. -
            -
          • If |previousId| was provided, let |watchId:long| be |previousId|; Otherwise, let |watchId:long| be an [=implementation-defined=] {{long}} that is greater than or equal to zero. @@ -650,6 +648,9 @@

          • If |document:Document| is [=Document/hidden=], wait for the |document| to become [=Document/visible=].
            • +
          • Go to wait for significant + change of geographic position. +

      -
    1. Wait for a significant change of geographic position. What - constitutes a significant change of geographic position is left - to the implementation. User agents MAY impose a rate limit on the - frequency position changes. +
    2. + Wait for a significant change of + geographic position. What constitutes a significant + change of geographic position is left to the implementation. + User agents MAY impose a rate limit on the frequency position + changes. +
      3. +
    3. If |document| is not [=Document/fully active=] or not + [=Document/visible=], go back to the previous step and again + wait for significant change of + geographic position. +
    4. If |watchTasks| [=list/contain|contains=] |watchId|, then:
        From 2c4dba646643d1806b729868202d3a1073631e0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Fri, 9 Jul 2021 11:09:06 +1000 Subject: [PATCH 6/7] Integrate better with visibility --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index f5949d4..0dae2a3 100644 --- a/index.html +++ b/index.html @@ -38,7 +38,7 @@ }; - +

        The Geolocation API provides access to geographical location @@ -639,7 +639,7 @@

      5. -
    5. Wait for document to become +
    6. Wait for document to become visible.
      1. Let |document:Document| be the [=current settings From e07e3bf82c8c4c3c73ede20cc64953043b3738e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Fri, 9 Jul 2021 14:55:29 +1000 Subject: [PATCH 7/7] fixup --- index.html | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/index.html b/index.html index 0dae2a3..ae7f081 100644 --- a/index.html +++ b/index.html @@ -38,7 +38,8 @@ }; - +

        The Geolocation API provides access to geographical location @@ -599,18 +600,7 @@

        {{long}}.

      2. Let |watchTasks:Set| be [=this=]'s - {{Geolocation/[[watchTasks]]}}. -
        3. -
      3. - If the [=current settings object=]'s [=associated `Document`=] is not [=fully active=]: -
          -
        1. - [=list/Empty=] |watchTasks|. -
          2. -
        2. - Return [=implementation-defined=] {{long}}. -
          3. -
        + {{Geolocation/[[watchTasks]]}}.
      4. If |previousId| was provided, let |watchId:long| be |previousId|; Otherwise, let |watchId:long| be an [=implementation-defined=] @@ -639,8 +629,7 @@

      7. -
    7. Wait for document to become - visible. +
    8. Wait for document to become visible.
      1. Let |document:Document| be the [=current settings object=]'s [=associated Document=].