Skip to content

MultipleObjectsReturned at /admin/wagtail_review/reviews/2/view/ #7

@AdrienLemaire

Description

@AdrienLemaire
Exception Value: | get() returned more than one Reviewer -- it returned 2!
Traceback
Environment:


Request Method: GET
Request URL: http://localhost:8000/admin/wagtail_review/reviews/2/view/

Django Version: 2.1.8
Python Version: 3.7.3
Installed Applications:
['home',
 'blog',
 'search',
 'wagtail.contrib.forms',
 'wagtail.contrib.redirects',
 'wagtail.embeds',
 'wagtail.sites',
 'wagtail.users',
 'wagtail.snippets',
 'wagtail.documents',
 'wagtail.images',
 'wagtail.search',
 'wagtail.admin',
 'wagtail.core',
 'modelcluster',
 'taggit',
 'wagtail_review',
 'django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles']
Installed Middleware:
['django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'wagtail.core.middleware.SiteMiddleware',
 'wagtail.contrib.redirects.middleware.RedirectMiddleware']



Traceback:

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/django/core/handlers/exception.py" in inner
  34.             response = get_response(request)

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  126.                 response = self.process_exception_by_middleware(e, request)

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  124.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/django/views/decorators/cache.py" in _wrapped_view_func
  44.         response = view_func(request, *args, **kwargs)

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/wagtail/admin/urls/__init__.py" in wrapper
  102.             return view_func(request, *args, **kwargs)

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/wagtail/admin/decorators.py" in decorated_view
  34.             return view_func(request, *args, **kwargs)

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/wagtail_review/views/admin.py" in view_review_page
  133.         reviewer = review.reviewers.get(user=request.user)

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/django/db/models/manager.py" in manager_method
  82.                 return getattr(self.get_queryset(), name)(*args, **kwargs)

File "/home/dori/.virtualenvs/project/lib/python3.7/site-packages/django/db/models/query.py" in get
  403.             (self.model._meta.object_name, num)

Exception Type: MultipleObjectsReturned at /admin/wagtail_review/reviews/2/view/
Exception Value: get() returned more than one Reviewer -- it returned 2!

Steps:

  • Install wagtail and follow getting started tutorial v2.4
  • Install wagtail-review
  • As admin, create 4 articles, and ask a review for the fourth post (I believe).
  • Login as editor, go to Reviews, but only the 3rd post (unpublished) appear (did I mistakenly ask a review for the 3rd post instead of the 4th?)
  • As editor, go as a review to self for the 4th post
  • from Reviews, click on the 4th post, the error happens.

Seeing 2 issues here:

  • review request from admin didn't show up in Reviews
  • Multiple reviewers (actually the same user twice) can be assigned to a post, but wagtail-review doesn't support it (wagtail_review/views/admin.py l.133)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions