-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-work examples and @waku/create-app #275
Comments
@waku-org/js-waku-developers wdyt? |
I suggest ownership of this repo moves to the eco dev team and to re-organize it in a way that it makes sense in terms for dev ex. Meaning in terms of ownership:
|
Proposed action items:
|
Created the repo for @waku-org/js-waku-developers - https://github.com/waku-org/js-waku-lab |
Renamed the repo to https://github.com/waku-org/waku-lab Update:It contains:
Example life cycle:I see example coming from:
create-react-appWe should re-work it and focus it on promoting templates with good defaults for Work items for it:
Since I have more context I'll go ahead and do it in following days (with lowest priority) if @waku-org/eco-dev is not against it. |
If a PoC / experiment get mature than indeed it can be handed over to Dev Rel that can define the example they want to use to showcase/document this experiment. They can decide to copy it over or can decide to do a brand new name. In terms of mandate for @waku-org/js-waku-developers: just have enough example to demonstrated the main APIs. So in the case of an experiment, it may then be merged into a dogfood webapp of lab.waku.org or kept as the dogfooding webapp. |
This is a feature request
Problem
In #260 couple of problems were noticed.
One is that as of now
examples
folder contains:waku
(e.gweb-chat
);js-waku
(e.glight-chat
);rln-js
,noise-js
,relay-direct-rtc
);At the same time
examples
are used in@waku/create-app
for other developers to start building on top ofjs-waku
.Proposed Solutions
(1) Develop a set of patterns convenient to use by other developers, these might be just templates from feat: example templates for fast development #271
(2) Separate space for experiments and PoCs. As of now these are
web-chat
,noise-*
,relay-direct-rtc
(3) Given that
@waku/create-app
should expose everything but main focus of this tool should be kept on first time developers and need to bootstrap their new development. That means these templates are defaults and only with an additional key provide the ability to fetch some other experiment / PoC.(4) Since we see a clear differentiation between a template for a developer and an experiment and a PoC I'd put last two groups to
lab.waku.org
(per comment) but then templates are left behind and I don't expect to have many of them so would be nice to move as well. In that caseexampels.waku.org
can be a shortcut to the repo.(5) Based on discussion from EcoDev monthly call and 2023 events retrospective, we should update the name of this repository to a more general name:
examples
. Post-update, identify broken links in https://docs.waku.org/.Last point obviously requires move discussion within the team.
Notes
Relative issue #271
The text was updated successfully, but these errors were encountered: