Skip to content

Commit 508ffd3

Browse files
committed
test: unskip tests
Now that the global state is not polluted anymore.
1 parent ec6f3d5 commit 508ffd3

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

packages/sdk/src/reliable_channel/reliable_channel.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ describe("Reliable Channel", () => {
186186
});
187187

188188
// TODO: https://github.com/waku-org/js-waku/issues/2648
189-
it.skip("Outgoing message is possibly acknowledged", async () => {
189+
it("Outgoing message is possibly acknowledged", async () => {
190190
const commonEventEmitter = new TypedEventEmitter<MockWakuEvents>();
191191
const mockWakuNodeAlice = new MockWakuNode(commonEventEmitter);
192192
const mockWakuNodeBob = new MockWakuNode(commonEventEmitter);

packages/sdk/src/reliable_channel/reliable_channel_encryption.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,7 @@ describe("Reliable Channel: Encryption", () => {
187187
expect(messageAcknowledged).to.be.false;
188188
});
189189

190-
// TODO: https://github.com/waku-org/js-waku/issues/2648
191-
it.skip("Outgoing message is possibly acknowledged", async () => {
190+
it("Outgoing message is possibly acknowledged", async () => {
192191
const commonEventEmitter = new TypedEventEmitter<MockWakuEvents>();
193192
const mockWakuNodeAlice = new MockWakuNode(commonEventEmitter);
194193
const mockWakuNodeBob = new MockWakuNode(commonEventEmitter);

packages/sds/src/message_channel/message_channel.spec.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,7 @@ describe("MessageChannel", function () {
185185
expect(timestampAfter).to.equal(timestampBefore + 1n);
186186
});
187187

188-
// TODO: test is failing in CI, investigate in https://github.com/waku-org/js-waku/issues/2648
189-
it.skip("should update lamport timestamp if greater than current timestamp and dependencies are met", async () => {
188+
it("should update lamport timestamp if greater than current timestamp and dependencies are met", async () => {
190189
const testChannelA = new MessageChannel(channelId, "alice");
191190
const testChannelB = new MessageChannel(channelId, "bob");
192191

@@ -207,8 +206,7 @@ describe("MessageChannel", function () {
207206
);
208207
});
209208

210-
// TODO: test is failing in CI, investigate in https://github.com/waku-org/js-waku/issues/2648
211-
it.skip("should maintain proper timestamps if all messages received", async () => {
209+
it("should maintain proper timestamps if all messages received", async () => {
212210
const aTimestampBefore = channelA["lamportTimestamp"];
213211
let timestamp = channelB["lamportTimestamp"];
214212
for (const m of messagesA) {

0 commit comments

Comments
 (0)