-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default import from one package #1353
Comments
I agree with the proposal and would like to provide some additional considerations to support the transition:
|
Keeping issue open to remove forced version after next release. |
FYI I defined next steps for this issue in the description. Moving back to "priority" column as no pending PR. |
Let's try to have remaining items done next week. |
|
Basic examples are using cc: @LordGhostX TODO of examples for me:
|
The last example to update is Proposing to resolve this issue and track upgrade to the last example in this issue waku-org/examples.waku.org#247 |
I agree with this proposal as it resolves and upgrades all examples, but one which is being tracked in a separate issue 👍 |
Closing in favor of waku-org/examples.waku.org#247 |
This is a feature request
Problem
Basic usage of js-waku involved importing for a couple of packages:
@waku/core
@waku/create
@waku/utils
See https://dev.waku.guide/browser/quick-start/
This kind be confusing for a developer.
More Context
The js-waku mono repo aims to be modular and to enable developer to limit their dependencies.
For more context, see #1159 for more context.
However, such characteristics are not desirable for a new comer, a developer trying out Waku or attempting to use it in a hackathon.
Hence, the
@waku/create
package was created to expose some API easy to use with good defaults.Proposed Solutions
The proposal is for one js-waku package to be a proxy package for other packages that are expected to be used in most basic example.
@waku/create
aimed to be said proxy package but fails at it as@waku/core
and@waku/utils
still need to be used.Proposal:
@waku/create
by a more attractive/general name. e.g.@waku/sdk
@waku/core
so that all js-waku examples can be purely done by installing and importing from@waku/sdk
(or whatever name we settle on).@waku/sdk
package created@waku/sdk
@waku/sdk
in examplesNotes
Cc @hackyguru @LordGhostX
The text was updated successfully, but these errors were encountered: