You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are not sure of the benefit of having retry with at least one success. From PoV of protocol if LightPush returns success it is safe to assume that message was relayed further but since TWN has history of being unstable and we are not sure of the quality of community run nodes we should try and see if it is needed.
Proposed Solutions
Todo:
Add telemetry for dogfooding app measuring successes / failures and delivery of message;
Attempt retry only if LightPush to all redundant peers failed;
Measure and save numbers;
Change to attempting retry for all failures (even if some are successful);
This is a change request
Problem
Right now
js-waku
will attempt to retry sending message even if one success happened at the same time for the message:js-waku/packages/sdk/src/protocols/lightpush/index.ts
Line 111 in 7a6247c
We are not sure of the benefit of having
retry
with at least one success. From PoV of protocol ifLightPush
returns success it is safe to assume that message was relayed further but since TWN has history of being unstable and we are not sure of the quality of community run nodes we should try and see if it is needed.Proposed Solutions
Todo:
LightPush
to all redundant peers failed;Notes
Discussion: link
The text was updated successfully, but these errors were encountered: