fix(create-pages): clean path mapping of pathless groups #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
this generates the correct mapping for paths using pathless groups fixes #1574
tylersayshi
force-pushed
the
fix-pathless-group-mapping
branch
from
e945118 to
3c05dbd
Compare
tylersayshi
changed the title
dai-shi
reviewed
Aug 4, 2025
| const hasWildcard = pathSpec.some((spec) => spec.type === 'wildcard'); | ||
| // remove pathless groups | ||
| const cleanPathSpec = pathSpec.filter( | ||
| (spec) => !(spec.type === 'literal' && spec.name.startsWith('(')), |
There was a problem hiding this comment.
I don't prefer this. Can you separate utils for define-router and create-pages? I hope to have separate files for each. Or only utils.ts should be for the define-router notion.
There was a problem hiding this comment.
how would you feel about moving the functions that are only used for create-pages just into the create-pages.ts file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this generates the correct mapping for paths using pathless groups
fixes #1574