Merge pull request #5 from wallarm/dev

Fix default tempfile mode and fix flacky tests

Author: yamax2

lib/cloud_storage/objects/base.rb

@@ -13,7 +13,7 @@ def size
         @internal.size
       end
 
-      def download(local_file = Tempfile.new)
+      def download(local_file = Tempfile.new('cloud', binmode: true))
         internal_download(local_file).tap(&:rewind)
       end
 

lib/cloud_storage/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CloudStorage
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

spec/cloud_storage/wrappers/gcs_spec.rb

@@ -148,15 +148,19 @@
     context 'when file exists' do
       let(:file) { File.open('spec/fixtures/test.txt', 'rb') }
       let!(:obj) { cli.upload_file(key: 'test5.txt', file: file) }
+      let(:tmp) { cli.find('test5.txt').download }
 
       after do
         file.close
 
         obj.delete!
+
+        tmp.close
+        tmp.unlink
       end
 
       it do
-        expect(cli.find('test5.txt').download.read).to eq("This is a test upload\n")
+        expect(tmp.read).to eq("This is a test upload\n")
       end
     end
 

spec/cloud_storage/wrappers/s3_spec.rb

@@ -141,16 +141,18 @@
     context 'when file exists' do
       let(:file) { File.open('spec/fixtures/test.txt', 'rb') }
       let!(:obj) { cli.upload_file(key: 'test5.txt', file: file) }
+      let(:tmp) { cli.find('test5.txt').download }
 
       after do
         file.close
 
         obj.delete!
-      end
 
-      it do
-        expect(cli.find('test5.txt').download.read).to eq("This is a test upload\n")
+        tmp.close
+        tmp.unlink
       end
+
+      it { expect(tmp.read).to eq("This is a test upload\n") }
     end
 
     context 'when file does not exists' do