From 22decafd130ba4a60a06f43bb9f805e01e76afa3 Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk Date: Thu, 10 Aug 2023 00:40:10 -0400 Subject: [PATCH 1/7] Bump operator memory limit --- charts/operator/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/operator/values.yaml b/charts/operator/values.yaml index e990470b..d936c571 100644 --- a/charts/operator/values.yaml +++ b/charts/operator/values.yaml @@ -11,7 +11,7 @@ extraEnvs: [] resources: limits: cpu: 1000m - memory: 600Mi + memory: 1Gi requests: cpu: 400m memory: 300Mi From 4b74bb293072a12b18e33e0ad939ab7dc269d344 Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk Date: Tue, 3 Oct 2023 11:33:26 -0500 Subject: [PATCH 2/7] feat: Adding support for k8s webhooks secret store --- .gitignore | 3 ++- charts/wandb/Chart.yaml | 4 ++-- charts/wandb/templates/role.yaml | 15 +++++++++++++++ charts/wandb/templates/rolebinding.yaml | 15 +++++++++++++++ 4 files changed, 34 insertions(+), 3 deletions(-) create mode 100644 charts/wandb/templates/role.yaml create mode 100644 charts/wandb/templates/rolebinding.yaml diff --git a/.gitignore b/.gitignore index 9432bb03..afcc238c 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ .vscode/ -dryrun.yaml \ No newline at end of file +dryrun.yaml +license.txt diff --git a/charts/wandb/Chart.yaml b/charts/wandb/Chart.yaml index 9f9263bd..e5ff4392 100644 --- a/charts/wandb/Chart.yaml +++ b/charts/wandb/Chart.yaml @@ -2,8 +2,8 @@ apiVersion: v2 name: wandb description: A Helm chart for deploying W&B to Kubernetes type: application -version: 0.2.0 -appVersion: "0.22.0" +version: 0.3.0 +appVersion: "0.43.0" icon: https://wandb.ai/logo.svg maintainers: - name: wandb diff --git a/charts/wandb/templates/role.yaml b/charts/wandb/templates/role.yaml new file mode 100644 index 00000000..91260b9f --- /dev/null +++ b/charts/wandb/templates/role.yaml @@ -0,0 +1,15 @@ +--- +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name: secret-manager-role + labels: + {{- include "wandb.labels" . | nindent 4 }} +rules: + - apiGroups: [""] + resources: ["secrets"] + verbs: ["get", "list", "create", "update", "patch", "delete"] + - apiGroups: [""] + resources: ["namespaces"] + verbs: ["get", "list"] +... \ No newline at end of file diff --git a/charts/wandb/templates/rolebinding.yaml b/charts/wandb/templates/rolebinding.yaml new file mode 100644 index 00000000..03d7b575 --- /dev/null +++ b/charts/wandb/templates/rolebinding.yaml @@ -0,0 +1,15 @@ +--- +apiVersion: rbac.authorization.k8s.io/v1 +kind: RoleBinding +metadata: + name: wandb-secret-manager-binding + labels: + {{- include "wandb.labels" . | nindent 4 }} +subjects: + - kind: ServiceAccount + name: {{ include "wandb.serviceAccountName" . }} +roleRef: + kind: Role + name: secret-manager-role + apiGroup: rbac.authorization.k8s.io +... From 3747ba2b0c3e74da5a45528240fd6ec1c2d71dd1 Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk Date: Fri, 6 Oct 2023 10:21:43 -0500 Subject: [PATCH 3/7] feat: Update role to check if NS exsists --- charts/wandb/Chart.yaml | 2 +- charts/wandb/templates/role.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/wandb/Chart.yaml b/charts/wandb/Chart.yaml index e5ff4392..ba2b96e4 100644 --- a/charts/wandb/Chart.yaml +++ b/charts/wandb/Chart.yaml @@ -3,7 +3,7 @@ name: wandb description: A Helm chart for deploying W&B to Kubernetes type: application version: 0.3.0 -appVersion: "0.43.0" +appVersion: "0.44.0-andrew.evolutioniq.hotfix.0" icon: https://wandb.ai/logo.svg maintainers: - name: wandb diff --git a/charts/wandb/templates/role.yaml b/charts/wandb/templates/role.yaml index 91260b9f..5a844f0a 100644 --- a/charts/wandb/templates/role.yaml +++ b/charts/wandb/templates/role.yaml @@ -8,8 +8,8 @@ metadata: rules: - apiGroups: [""] resources: ["secrets"] - verbs: ["get", "list", "create", "update", "patch", "delete"] + verbs: ["get", "create", "update", "delete"] - apiGroups: [""] resources: ["namespaces"] - verbs: ["get", "list"] + verbs: ["get"] ... \ No newline at end of file From a65283d21888effc982abc0bbaa87cf62ba99711 Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk Date: Fri, 6 Oct 2023 10:59:27 -0500 Subject: [PATCH 4/7] feat: Bump the appVersion to 0.44.0 --- charts/wandb/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/wandb/Chart.yaml b/charts/wandb/Chart.yaml index ba2b96e4..cdeedac5 100644 --- a/charts/wandb/Chart.yaml +++ b/charts/wandb/Chart.yaml @@ -3,7 +3,7 @@ name: wandb description: A Helm chart for deploying W&B to Kubernetes type: application version: 0.3.0 -appVersion: "0.44.0-andrew.evolutioniq.hotfix.0" +appVersion: "0.44.0" icon: https://wandb.ai/logo.svg maintainers: - name: wandb From 39959cf926a98b4130a8fa2bc5336a9e5b21257d Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk Date: Mon, 16 Oct 2023 16:27:40 -0500 Subject: [PATCH 5/7] fix: Testing with 0.44.1 --- charts/wandb/Chart.yaml | 2 +- charts/wandb/templates/_helpers.tpl | 14 +++++++++++++- charts/wandb/templates/role.yaml | 2 +- charts/wandb/templates/rolebinding.yaml | 4 ++-- 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/charts/wandb/Chart.yaml b/charts/wandb/Chart.yaml index cdeedac5..fb879133 100644 --- a/charts/wandb/Chart.yaml +++ b/charts/wandb/Chart.yaml @@ -3,7 +3,7 @@ name: wandb description: A Helm chart for deploying W&B to Kubernetes type: application version: 0.3.0 -appVersion: "0.44.0" +appVersion: "0.44.1" icon: https://wandb.ai/logo.svg maintainers: - name: wandb diff --git a/charts/wandb/templates/_helpers.tpl b/charts/wandb/templates/_helpers.tpl index b8117ae9..3f5316ac 100644 --- a/charts/wandb/templates/_helpers.tpl +++ b/charts/wandb/templates/_helpers.tpl @@ -87,4 +87,16 @@ SQL configuration helpers, MySQL 8 needs session variable permissions {{- if eq (include "wandb.mysqlVersion" .) "8" }} {{- printf "SESSION_VARIABLES_ADMIN," -}} {{- end }} -{{- end }} \ No newline at end of file +{{- end }} + + +{{/* +Secrets Manager Role and Binding +*/}} +{{- define "wandb.secretManagerRoleName" -}} +{{- printf "%s-secret-manager-role" (include "wandb.fullname" .) -}} +{{- end -}} + +{{- define "wandb.secretManagerRoleBindingName" -}} +{{- printf "%s-secret-manager-binding" (include "wandb.fullname" .) -}} +{{- end -}} \ No newline at end of file diff --git a/charts/wandb/templates/role.yaml b/charts/wandb/templates/role.yaml index 5a844f0a..f8899783 100644 --- a/charts/wandb/templates/role.yaml +++ b/charts/wandb/templates/role.yaml @@ -2,7 +2,7 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: - name: secret-manager-role + name: {{ include "wandb.secretManagerRoleName" . }} labels: {{- include "wandb.labels" . | nindent 4 }} rules: diff --git a/charts/wandb/templates/rolebinding.yaml b/charts/wandb/templates/rolebinding.yaml index 03d7b575..691d024f 100644 --- a/charts/wandb/templates/rolebinding.yaml +++ b/charts/wandb/templates/rolebinding.yaml @@ -2,7 +2,7 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: RoleBinding metadata: - name: wandb-secret-manager-binding + name: {{ include "wandb.secretManagerRoleBindingName" . }} labels: {{- include "wandb.labels" . | nindent 4 }} subjects: @@ -10,6 +10,6 @@ subjects: name: {{ include "wandb.serviceAccountName" . }} roleRef: kind: Role - name: secret-manager-role + name: {{ include "wandb.secretManagerRoleName" . }} apiGroup: rbac.authorization.k8s.io ... From 63d0fe0ab8fa86cc0c91dc08dbac819bae28b4cc Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk <77289967+wandb-zacharyblasczyk@users.noreply.github.com> Date: Mon, 23 Oct 2023 17:17:46 -0500 Subject: [PATCH 6/7] Update role.yaml --- charts/wandb/templates/role.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/charts/wandb/templates/role.yaml b/charts/wandb/templates/role.yaml index f8899783..2dae05ec 100644 --- a/charts/wandb/templates/role.yaml +++ b/charts/wandb/templates/role.yaml @@ -12,4 +12,3 @@ rules: - apiGroups: [""] resources: ["namespaces"] verbs: ["get"] -... \ No newline at end of file From 9a2b8ac3c67e362296c2e7eb831dc652e54ad459 Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk <77289967+wandb-zacharyblasczyk@users.noreply.github.com> Date: Mon, 23 Oct 2023 17:18:07 -0500 Subject: [PATCH 7/7] Update rolebinding.yaml --- charts/wandb/templates/rolebinding.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/charts/wandb/templates/rolebinding.yaml b/charts/wandb/templates/rolebinding.yaml index 691d024f..a27890e6 100644 --- a/charts/wandb/templates/rolebinding.yaml +++ b/charts/wandb/templates/rolebinding.yaml @@ -12,4 +12,3 @@ roleRef: kind: Role name: {{ include "wandb.secretManagerRoleName" . }} apiGroup: rbac.authorization.k8s.io -...