Doesn't work on .io / .de / .cc / .ly etc

[jvgeee]

I'm having errors using this module for many non-traditional TLDs. Can be replicated with any of the following domain names:

grabcode.fr
tablo.io
mahe.sh
live.dk
hadouken.io
nigel.in
cade.jp
live.no
ben.gy
live.cn
seedtech.io
sinakresse.de
dialcom.cc
genealassemb.ly
jasperwuts.nl
delga.do
doyouevenlift.io
labrat.no
thatstartupshow.tv
app.io
thisthing.us
ashw.in
melbdev.io
q-design.se
kros.ch
inbox.ru
adventurecapital.vc
markusgiesen.de
freesoul.cc
tolog.ch
motionstory.no
web.de
erck.de
bunts.io
embry.io
grabcode.fr
tablo.io
mahe.sh
live.dk
hadouken.io
nigel.in
cade.jp
live.no
ben.gy
live.cn
seedtech.io
sinakresse.de
dialcom.cc
genealassemb.ly
jasperwuts.nl
delga.do
doyouevenlift.io
labrat.no
thatstartupshow.tv
app.io
thisthing.us
ashw.in
melbdev.io
q-design.se
kros.ch
inbox.ru
adventurecapital.vc
markusgiesen.de
freesoul.cc
tolog.ch
motionstory.no
web.de
erck.de
bunts.io
embry.io
``

I'm loading them in like so:

var d = parse(domain);
console.log(d.sld);

All of the above return `null`. Any easy fixes for this?

[wankdanker]

I think this is due to a previous request that any country specific domains be treated such that 'inbux.ru' is treated as the TLD. I can easily create a flag to turn that feature off.

[wankdanker]

Changed the behavior to require the mergeCountry flag if someone wants merged country TLDs. So, without this flag, it should behave as you may expect.

Released 2.0.0 to npm, give it a shot.

[jvgeee]

Awesome mate! Thanks for the speedy response, will give it a go tomorrow when I'm back in action. Very handy module btw! Great job.

[jvgeee]

Mmm think this update broke a few things. Now by default it doesn't work for things like:

whatever.com.au
whatever.edu.au

for these, trying to return the sld gives you com or edu. But the .ly and .io names work now!

What am I doing wrong here?

[wankdanker]

You're not doing anything wrong. There is a slight disconnect between what different people consider to be sld, tld and other parts. The flag that I just created reverted the default behavior back to what the module originally did which was exactly this:

Given "host.subdomain.domain.com":

• tld - "com" -- the first part on the right
• sld - "domain" -- the second part from the right
• host - "host" -- the left-most part
• domainName - "domain.com" -- always the commonly referred to part (sld + tld)
• domain - "subdomain.domain.com" -- everything except the host

Strictly speaking, the sld (as defined above) in "whatever.com.au" IS "com" because it is the second part from the right. However, some prefer that in some cases we treat "com.au" as the tld and then "whatever" as sld. That's what the mergeCountry flag enables. However, in some cases there, like bit.ly, github.io, or mail.ru where there is a clever use of a country specific tld, it is NOT desired to have the merged country.

I haven't put much thought into solving that problem. I suppose we could come up with a list of parts like ['com','org','net','edu'] and if they occur as the sld then merge it with the tld and shift everything else over...