SettingsState: put lang change into runInAction() (#380)

warpdesign · web-flow · commit b28aec8cc120 · 2023-02-10T16:07:55.000+01:00
This prevents a warning from MobX since state cannot be modified out of an action.
Not sure why this happens since setLanguage is already set as action: I guess it has
something to do with the fact that it's an async function.
diff --git a/src/state/settingsState.ts b/src/state/settingsState.ts
@@ -95,7 +95,7 @@ export class SettingsState {
         // finally set requested language
         i18next.changeLanguage(lang)
 
-        this.lang = i18next.language
+        runInAction(() => (this.lang = i18next.language))
     }
 
     setDefaultTerminal(cmd: string): void {

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ export class SettingsState {`
`95`	`95`	`// finally set requested language`
`96`	`96`	`i18next.changeLanguage(lang)`
`97`	`97`
`98`		`- this.lang = i18next.language`
	`98`	`+ runInAction(() => (this.lang = i18next.language))`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`setDefaultTerminal(cmd: string): void {`