Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add default to fields that also have skip_serializing_if #466

Open
brooksmtownsend opened this issue Oct 22, 2024 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest This issue is specifically designated as a good issue for Hacktoberfest rust Pull requests that update Rust code

Comments

@brooksmtownsend
Copy link
Member

In the Metadata example: https://github.com/wasmCloud/wadm/blob/main/crates/wadm-types/src/lib.rs#L180 if you construct a manifest and try to deploy it using wadm-client, the annotations field will not be serialized, and then wadm will fail to deserialize the manifest.

For any of our BTreeMap / HashMaps that have the serde skip_serializing_if annotation, we also need to add default there (see labels for an example)

This is a great first issue to fix a frustrating bug.

@brooksmtownsend brooksmtownsend added bug Something isn't working good first issue Good for newcomers hacktoberfest This issue is specifically designated as a good issue for Hacktoberfest rust Pull requests that update Rust code labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest This issue is specifically designated as a good issue for Hacktoberfest rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

1 participant