Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure LinkScaler validates values #88

Open
brooksmtownsend opened this issue Apr 17, 2023 · 1 comment
Open

Ensure LinkScaler validates values #88

brooksmtownsend opened this issue Apr 17, 2023 · 1 comment
Labels
roadmap Planned work
Milestone

Comments

@brooksmtownsend
Copy link
Member

brooksmtownsend commented Apr 17, 2023

At the moment, the LinkScaler only ensures that a link exists between an actor and a provider but does not assert that the values specified are correct. See this TODO for where this code would go: https://github.com/wasmCloud/wadm/blob/main/src/scaler/spreadscaler/link.rs#L119

Essentially we already have this information in the lattice data stream for linkdefs so we should check to see if the linkdef exists so that we can issue a delete and then a put command.

@stale
Copy link

stale bot commented Jun 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Jun 16, 2023
@brooksmtownsend brooksmtownsend added roadmap Planned work and removed stale labels Jun 16, 2023
@brooksmtownsend brooksmtownsend added this to the v0.5.0 milestone Aug 3, 2023
@brooksmtownsend brooksmtownsend modified the milestones: v0.5.0, v0.6.0 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap Planned work
Projects
None yet
Development

No branches or pull requests

1 participant