Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rutie-derive and rutie-derive-macros to `rutie #55

Open
Hywan opened this issue May 25, 2021 · 1 comment
Open

Migrate rutie-derive and rutie-derive-macros to `rutie #55

Hywan opened this issue May 25, 2021 · 1 comment
Assignees
@Hywan
Labels
🎉 enhancement New feature or request

Comments

@Hywan
Copy link
Contributor

Hywan commented May 25, 2021 •
edited
Loading

See danielpclark/rutie#145 for the context.

The idea is to migrate rutie-derive and rutie-derive-macros inside rutie itself. The crates must be polished first I reckon. The question is: Where do we polish it? Here, or inside rutie?
@Hywan Hywan added the 🎉 enhancement New feature or request label May 25, 2021
@Hywan Hywan self-assigned this May 25, 2021
@ilyazub
Copy link

ilyazub commented Jan 13, 2022

@Hywan I'm working on a PR with migration. I've copied source files of rutie-derive and rutie-derive-macros to the newly created rutie/src/dsl folder and moved rutie/src/dsl.rs to rutie/src/dsl/mod.rs. I want to keep the directory structure of rutie with the least possible changes.

Not sure it's the best approach. Currently fixing compilation errors.

Maybe a better option is move rutie/src/* to rutie/crates/rutie and copy crates/{rutie-derive,rutie-derive-macros} from this repository to rutie/crates/. Similar to what you've done here.

What do you think?

ilyazub added a commit to ilyazub/rutie that referenced this issue Jan 19, 2022
@ilyazub
Move rutie to crates/rutie and add it as a workspace
faa178f 
Copied rutie-derive and rutie-derive-macros crates with Git history
from https://github.com/wasmerio/wasmer-ruby.

According to wasmerio/wasmer-ruby#55 and
danielpclark#145.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hywan Hywan

Labels
🎉 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilyazub @Hywan