-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the new client with the Queue component #57
Comments
UpdateCreated branch for the story. Some CMake changes were needed to the Queue's CMake files (disable tests, which caused compilation errors, made the include directories public, changed the name of the queue header file since it collided with boost queue for intellisense purposes). Extended the Communicator class to take two functions, one to get messages and one to push commands. |
UpdateRebased and continue testing with awaitable versions of the queue methods. |
UpdateSome issues were addressed: ternary operator used in http_client.cpp:132 was not correctly deducing the type of string when there was no message getter function, resulting in the code hanging on a wrongly deduced awaitable. Re authentication attempts fixed by removing the token timer extension, instead the timer can be cancelled, waking up the coroutine waiting on it. |
UpdateDraft PR has been opened. Continuing with testing scenarios. |
UpdateAdded tests, did some refactoring on the Queue to enable using GMock with it. Addressed comments on the PR's draft. |
Description
As part of the development of the new agent MVP, it is necessary to integrate the new client with the Queue component.
Take into account the following:
stateless
andstateful
requests should get messages to be sent from the Queue.command
responses should be stored in the Queue.For more considerations, see the spike issue.
The text was updated successfully, but these errors were encountered: