Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the new client with the Queue component #57

Closed
TomasTurina opened this issue Aug 1, 2024 · 5 comments · Fixed by #82
Closed

Integrate the new client with the Queue component #57

TomasTurina opened this issue Aug 1, 2024 · 5 comments · Fixed by #82
Assignees
Labels

Comments

@TomasTurina
Copy link
Member

Description

As part of the development of the new agent MVP, it is necessary to integrate the new client with the Queue component.

Take into account the following:

  • stateless and stateful requests should get messages to be sent from the Queue.
    • The communicator can specify the type and number of messages to be fetched from the Queue.
  • command responses should be stored in the Queue.
  • The communicator should only handle requests. No need to process messages.

For more considerations, see the spike issue.

@wazuhci wazuhci moved this to Backlog in Release 5.0.0 Aug 1, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 5.0.0 Aug 9, 2024
@jr0me
Copy link
Member

jr0me commented Aug 12, 2024

Update

Created branch for the story. Some CMake changes were needed to the Queue's CMake files (disable tests, which caused compilation errors, made the include directories public, changed the name of the queue header file since it collided with boost queue for intellisense purposes).

Extended the Communicator class to take two functions, one to get messages and one to push commands.

@jr0me
Copy link
Member

jr0me commented Aug 12, 2024

Update

Rebased and continue testing with awaitable versions of the queue methods.

@jr0me
Copy link
Member

jr0me commented Aug 14, 2024

Update

Some issues were addressed: ternary operator used in http_client.cpp:132 was not correctly deducing the type of string when there was no message getter function, resulting in the code hanging on a wrongly deduced awaitable. Re authentication attempts fixed by removing the token timer extension, instead the timer can be cancelled, waking up the coroutine waiting on it.

@jr0me jr0me linked a pull request Aug 14, 2024 that will close this issue
1 task
@jr0me
Copy link
Member

jr0me commented Aug 15, 2024

Update

Draft PR has been opened. Continuing with testing scenarios.

@jr0me
Copy link
Member

jr0me commented Aug 15, 2024

Update

Added tests, did some refactoring on the Queue to enable using GMock with it. Addressed comments on the PR's draft.

@wazuhci wazuhci moved this from In progress to Done in Release 5.0.0 Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants