Skip to content

Commit 228e8ee

Browse files
committed
Fix release based releases without label
If not explicit label or name is given, use filename of download url for asset pattern matching.
1 parent ab8e10e commit 228e8ee

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

package_control/clients/github_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,10 @@ def _get_releases(user_repo, tag_prefix=None, page_size=1000):
244244
version,
245245
release['published_at'][0:19].replace('T', ' '),
246246
[
247-
((a['label'], a['browser_download_url']))
247+
(
248+
a['label'] or a['browser_download_url'].rpartition("/")[-1],
249+
a['browser_download_url']
250+
)
248251
for a in release['assets']
249252
if a['state'] == 'uploaded'
250253
]

package_control/clients/gitlab_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,10 @@ def _get_releases(user_repo, tag_prefix=None, page_size=1000):
245245
version,
246246
release['released_at'][0:19].replace('T', ' '),
247247
[
248-
((a['name'], a['direct_asset_url']))
248+
(
249+
a['name'] or a['direct_asset_url'].rpartition("/")[-1],
250+
a['direct_asset_url']
251+
)
249252
for a in release['assets']['links']
250253
]
251254
)

0 commit comments

Comments
 (0)