-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add RegexLab - Regex pattern library for Sublime Text 4 #9239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add RegexLab - Regex pattern library for Sublime Text 4
Add RegexLab - Regex pattern library for Sublime Text 4 (fix indentation)
nk9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this could use a previous_names key.
|
Hi Nick ^^ This is a complete rewrite rather than an evolution of RegexPortfolio. I'm wondering if using Also, since there are no longer any references to RegexPortfolio in the r.json file, I thought it might be better to keep it separate. From my perspective, since the old project is definitively retired, it might be cleaner to move forward without the migration path. What do you think? Otherwise, I can add a Cheers |
|
Thanks for the quick reply! I see that RegexPortfolio is still on PackageControl.io, even though it's been removed from the channel. And I expect that there are still users who installed it forever ago and just haven't removed it. That's why I suggested it. I'm not a PC expert, though, and I know that longstanding uses of I did a spot check of other packages and their use of this key. None of their package names appear in the index anymore either, so I don't think that's a reason not to do this. I don't think |
|
You're absolutely right! I'll update the r.json in my Package Control fork to include: "previous_names": ["RegexPortfolio"] ^^ |
|
Checking in on this. Is there anything preventing this from being merged? @braver |
|
@nk9 Mostly just availability on my end. A package like this takes a bit more time to review than a color scheme or language syntax. And I must admit, the OP looks like it's AI generated with the emoji overdose and overwrought statements like "The package follows ST4 best practices and uses "tags": true for automatic version synchronization.". Also, the repo has 2 commits which is suspicious for a package that seems quite ambitious. Now this conversation here reinsured me that some humans put care and attention into it, so it's fine, but I'm sure you can imagine we see quite a bit of slop these days. Putting RegexPortfolio into previous names seems like a good move by the way. It's close enough to the new package and it cleans up the registry even though I doubt there are too many actual users out there. I'll have a look at the package :) |
|
Hello, Thanks for your feedback and for taking the time to look into it. As I mentioned to @nk9, the documentation parts were indeed AI-generated and then reviewed/edited on my side, including some of the repo metadata. So I totally understand how it might give off that impression. The coding part isn’t suspicious though: the workflow is simply built around a very “workbench”-style DEV branch, and a cleaned-up main where I squash everything to keep a tidy, readable history. That’s why the visible commit count is so low. Thanks again for the review ^^ Happy to clarify or adjust anything if needed. P.S.: By the way you also added quite a few CI/CD checks… And I passed them all =þ And for transparency: I also documented my unit test coverage in the Contributing section. |
Or effectively hardly any history at all depending on your perspective on such things. But thanks for explaining 😄 Remarks on the package:
Since your package is reading from and writing to files, did you test your package also when packaged (use the Create Package File command and then install that instead)? |
It does, that’s what the Context.sublime-menu file is for. |
|
Ah yes you’re absolutely right! I had completely forgotten about that. I added this little helper very late one night thinking it might be useful, but if it risks causing menu conflicts, I can remove it or move it somewhere more appropriate. Thanks for pointing it out! |
Well, it's that it's sometimes hard to make things in there conditional or truly contextual. But if every package adds stuff in there just cause it might be useful, users end up with a very long context menu. So, if you could put your context menu behind a settings that could work. In general though, ST use is more driven by the command palette, keybindings and other menus than right-clicking things a lot. |
|
Thanks to both of you! =) I realized I made a bit of a blunder. 😅 My tests were passing locally, but I completely overlooked the difference between dev mode and the packaged environment. I definitely needed a mutable workspace for the integrity checks. I've pushed the fixes, and unit tests + CI are all green now. That's what happens when coding at 3 AM... eyes start crossing! 😵💫 Thanks again for the feedback! @nk9 => KaminoU/RegexLab@b958c1c cheers |

Add RegexLab
RegexLab is a comprehensive regex pattern library and testing environment for Sublime Text 4.
Key Features:
Quality Assurance:
Links:
There are no packages like it in Package Control.
While similar packages exist (RegExLink, RegexExplainTip), RegexLab is unique in offering:
The package follows ST4 best practices and uses
"tags": truefor automatic version synchronization.