Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks annotation limit #749

Open
cbackas opened this issue Dec 7, 2023 · 4 comments
Open

Checks annotation limit #749

cbackas opened this issue Dec 7, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers in progress stale

Comments

@cbackas
Copy link

cbackas commented Dec 7, 2023

Hey I use this for some personal projects and thought I'd bring it into work to increase the visibility of issues so we can start getting them all fixed. Well turns out our projects have many more than 50 annotations and I'd like to have them all in github but this action simply drops everything after 50.

I went ahead and forked the repo and threw together the changes to chunk the annotations and send them all with rate limit handling but the contrib guidelines said to make an issue before PRs so here I am.

@ocean90 since you seem to be the main person around here, does this sound like something we could get merged in?

Update: went to test my first pass of the code and it didn't work but I got it fixed up and uploaded 2607 annotations no problemo
image

@cbackas
Copy link
Author

cbackas commented Dec 15, 2023

@ocean90 any any feedback on this concept? Would love to know if I should commit to our organization using a fork or not.

As a side note, I'd be happy to change the HTTP requests to use the octokit/rest.js library since its what github recommends in their docs. This would remove the need to handle rate limiting in the 'request' function (and can maybe delete the function entirely) and also remove the manual handling of headers. Another dependency is something to consider tho, so just let me know.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 31, 2023
@wearerequired wearerequired deleted a comment from cbackas Dec 31, 2023
@github-actions github-actions bot removed the stale label Jan 1, 2024
@ocean90 ocean90 added enhancement New feature or request good first issue Good for newcomers labels Jan 2, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 18, 2024
@cbackas
Copy link
Author

cbackas commented Jan 19, 2024

#764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers in progress stale
Projects
None yet
Development

No branches or pull requests

2 participants