Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with export #1

Open
vapecloudbear opened this issue Apr 27, 2020 · 7 comments
Open

Issue with export #1

vapecloudbear opened this issue Apr 27, 2020 · 7 comments

Comments

@vapecloudbear
Copy link

Linking old post with pastebin of error and sample data. Gamealition#4

@weaves7
Copy link
Owner

weaves7 commented May 22, 2020

Sorry, time got away from me. What Minecraft and SignShop versions does the fix need to be for at this time?

@TomLewis
Copy link

Paper 1.12.2 please!

@weaves7
Copy link
Owner

weaves7 commented Nov 26, 2021

Well I totally forgot you were on 1.12.2 I updated for 1.13+ and SignShop v3. https://github.com/weaves7/SignShopExport/releases/tag/2.0.0-dev

Let me know if you still care, and if you might test this for me.

@TomLewis
Copy link

Still interested! We will move to 1.13+ at some point, but i've been saying that for the last year.

Wouldn't mind a nice MySQL connection while you're at it!

@weaves7
Copy link
Owner

weaves7 commented Nov 28, 2021

Ok, then I won't bother going back to 1.12.2 since I never messed with any of those versions anyway. Maybe this will be an incentive for you to update :)

So far I have a seemingly working version with MySQL output. It just outputs to a table called signshop_export with columns called server_name, time_stamp, shop_json their datatypes being VARCHAR, TIMESTAMP, LONGTEXT respectively. As I have mentioned in another repo I am not experienced in MySQL so I have to learn it as I go. I also still need to make the database transaction asynchronous. This is just meant to be a proof of concept at the moment. I need someone to test it that knows the database side and whether the data looks correct. I was also wondering if it would be better to add 1 shop per row in the database? I have pushed the changes to this repo and will add the jar to the releases. I will be awaiting your feedback.

@TomLewis
Copy link

My background is website development and have worked with SQL for maybe 15 years, so that's the one thing I can help with! Database schema design & optimized SQL statements!

@weaves7
Copy link
Owner

weaves7 commented Nov 28, 2021

Awesome, if you could provide a schema with PreparedStatements for creating the table and one(or more) for adding/updating/removing a shop. The update() and createTables() methods are the only ones so far that are working with the database. Make sure you are sitting down before you look at the current statements, they are quite ugly. https://github.com/weaves7/SignShopExport/blob/master/src/main/java/roycurtis/signshopexport/DataBaseHandler.java#L27

I figure it would be better to follow the properties listed in the FORMAT.md file. perhaps with added server and timestamp columns. The invItems column would likely still need to be an array of Item JSON since it will be variable in length and content.
https://github.com/weaves7/SignShopExport/blob/master/docs/FORMAT.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants