Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses unlicensed opentracing-contrib/go-grpc #160

Open
asuffield opened this issue Jul 4, 2019 · 2 comments
Open

Uses unlicensed opentracing-contrib/go-grpc #160

asuffield opened this issue Jul 4, 2019 · 2 comments

Comments

@asuffield
Copy link

server/server.go imports github.com/opentracing-contrib/go-grpc

This repo doesn't have a license (opentracing-contrib/go-grpc#3), so this makes weaveworks/common unusable for us.

go-grpc looks trivial, so if getting it licensed is somehow hard, it would probably not take very long to rewrite...

@bboreham
Copy link
Collaborator

Thanks for raising this.
The code in that package was from https://github.com/grpc-ecosystem/grpc-opentracing, which does display a licence. I think we can assume this is an oversight in copying files rather than a real lack of licence.

I'll try again to make contact with its maintainers.

@dholbach
Copy link
Contributor

The upstream issue is now fixed. Can we update our dep?

yeya24 pushed a commit to yeya24/common that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants