Dot not allowed for aws azure minio proxy

[khauser]

With grafana/loki#800 I found a problem with the dot handling in this file: https://github.com/weaveworks/common/blob/master/aws/config.go

What I like to do is having a s3 talking minio azureblobs proxy next to my loki service in k8s. For this added the following url to the loki values.yaml:

s3://<azure-storage-key>:<azure-storage-secret>@minio:9000/logs
s3forcepathstyle: true

This is a normal requirement for a docker or k8s environment.

But the the problem now is that the script https://github.com/weaveworks/common/blob/master/aws/config.go thinks (because of a missing dot) that the minio string belongs to an aws standard defined url. But it's not in this case. It shall be an endpoint.

Renaming into minio.local would only help in docker but not in k8s where dots in names are not allowed.

Do you have any suggestions how to handle this? Now I must use minio as an external service.

[bboreham]

The upstream issue is now closed - does this still need anything here?