refactor(core): Add an app instance to activeApps before rendering (#482)

* refactor(core): Add an app instance to activeApps before rendering

* workflow: modify pull request template

Author: zhoushaw

.eslintrc.js

@@ -3,7 +3,13 @@ const NodeGlobals = ['module', 'require'];
 module.exports = {
   root: true,
   parser: '@typescript-eslint/parser',
-  ignorePatterns: ['**/dist', 'dev/', 'api-extractor.json', 'packages/*/dist'],
+  ignorePatterns: [
+    '**/dist',
+    'dev/',
+    'shimsVue.d.ts',
+    'api-extractor.json',
+    'packages/*/dist',
+  ],
   parserOptions: {
     sourceType: 'module',
   },

.github/pull_request_template.md

@@ -1,9 +1,6 @@
-# PR Details
-
-<!--- Provide a general summary of your changes in the Title above -->
-
 ## Description
 
+<!--- Provide a general summary of your changes in the Title above -->
 <!--- Describe your changes in detail -->
 
 ## Related Issue

dev/app-vue-2/src/shims-vue.d.ts

@@ -0,0 +1,8 @@
+/* eslint-disable */
+declare module '*.vue' {
+  /* eslint-disable */
+  // eslint-disable-next-line
+  import type Vue from 'vue';
+  // eslint-disable-next-line
+  export default Vue;
+}

dev/app-vue-2/src/shimsVue.d.ts

@@ -1,3 +1,4 @@
+/* eslint-disable */
 declare module '*.vue' {
   import type { DefineComponent } from 'vue';
   const component: DefineComponent<{}, {}, any>;

dev/app-vue-3/src/shims-vue.d.ts

@@ -0,0 +1,6 @@
+/* eslint-disable */
+declare module '*.vue' {
+  import type { DefineComponent } from 'vue';
+  const component: DefineComponent<{}, {}, any>;
+  export default component;
+}

dev/app-vue-vite/src/shims-vue.d.ts dev/app-vue-3/src/shimsVue.d.tsdev/app-vue-vite/src/shims-vue.d.ts renamed to dev/app-vue-3/src/shimsVue.d.ts

@@ -30,7 +30,7 @@
       "prettier --write"
     ],
     "*.ts?(x)": [
-      "eslint --fix",
+      "eslint --fix --config .eslintrc.js",
       "prettier --parser=typescript --write"
     ]
   },

dev/app-vue-vite/src/shimsVue.d.ts

@@ -232,9 +232,9 @@ export class App {
       return false;
     }
     this.hooks.lifecycle.beforeMount.emit(this.appInfo, this, true);
+    this.context.activeApps.push(this);
 
     await this.addContainer();
-    this.context.activeApps.push(this);
     this.callRender(provider, false);
     this.display = true;
     this.hooks.lifecycle.afterMount.emit(this.appInfo, this, true);
@@ -266,6 +266,7 @@ export class App {
     this.active = true;
     this.mounting = true;
     try {
+      this.context.activeApps.push(this);
       // add container and compile js with cjs
       const { asyncScripts } = await this.compileAndRenderContainer();
       if (!this.stopMountAndClearEffect()) return false;
@@ -275,7 +276,6 @@ export class App {
       // Existing asynchronous functions need to decide whether the application has been unloaded
       if (!this.stopMountAndClearEffect()) return false;
 
-      this.context.activeApps.push(this);
       this.callRender(provider, true);
       this.display = true;
       this.mounted = true;