Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Minor inconsistency in MFE Guides #5957

Open
kirillbashtenko opened this issue Jul 16, 2024 · 0 comments
Open

[Bug]: Minor inconsistency in MFE Guides #5957

kirillbashtenko opened this issue Jul 16, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@kirillbashtenko
Copy link
Contributor

Version

System:
    OS: macOS 13.5.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 46.62 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 126.0.6478.127
    Safari: 17.4.1
  npmPackages:
    @modern-js/app-tools: 2.55.0 => 2.55.0 
    @modern-js/eslint-config: 2.55.0 => 2.55.0 
    @modern-js/plugin-garfish: 2.55.0 => 2.55.0 
    @modern-js/runtime: 2.55.0 => 2.55.0 
    @modern-js/tsconfig: 2.55.0 => 2.55.0

Details

Hi, in micro-frontend guides here https://modernjs.dev/en/guides/topic-detail/micro-frontend/c02-development.html
We can see

 runtime: {
    router: true,
    state: true,
    masterApp: true,
  },

but accepted types for masterApp is RuntimeUserConfig.masterApp?: Config | undefined

Options:
1 Changing guides to reflect new changes
2 Extend accepted types to prevent this inconsistency

I can create a PR with a fixed one once we agree what is the best option.

Reproduce link

https://github.com/kirillbashtenko/modern-js-example

Reproduce Steps

1 pnpm install
2 open modern.config.ts

@kirillbashtenko kirillbashtenko added the bug Something isn't working label Jul 16, 2024
@zllkjc zllkjc added the documentation Improvements or additions to documentation label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants