We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System: OS: macOS 13.5.1 CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz Memory: 46.62 MB / 32.00 GB Shell: 5.9 - /bin/zsh Browsers: Chrome: 126.0.6478.127 Safari: 17.4.1 npmPackages: @modern-js/app-tools: 2.55.0 => 2.55.0 @modern-js/eslint-config: 2.55.0 => 2.55.0 @modern-js/plugin-garfish: 2.55.0 => 2.55.0 @modern-js/runtime: 2.55.0 => 2.55.0 @modern-js/tsconfig: 2.55.0 => 2.55.0
Hi, in micro-frontend guides here https://modernjs.dev/en/guides/topic-detail/micro-frontend/c02-development.html We can see
runtime: { router: true, state: true, masterApp: true, },
but accepted types for masterApp is RuntimeUserConfig.masterApp?: Config | undefined
Options: 1 Changing guides to reflect new changes 2 Extend accepted types to prevent this inconsistency
I can create a PR with a fixed one once we agree what is the best option.
https://github.com/kirillbashtenko/modern-js-example
1 pnpm install 2 open modern.config.ts
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Version
Details
Hi, in micro-frontend guides here https://modernjs.dev/en/guides/topic-detail/micro-frontend/c02-development.html
We can see
but accepted types for masterApp is RuntimeUserConfig.masterApp?: Config | undefined
Options:
1 Changing guides to reflect new changes
2 Extend accepted types to prevent this inconsistency
I can create a PR with a fixed one once we agree what is the best option.
Reproduce link
https://github.com/kirillbashtenko/modern-js-example
Reproduce Steps
1 pnpm install
2 open modern.config.ts
The text was updated successfully, but these errors were encountered: