Skip to content

test: run e2e cases with Rspack incremental #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

Add a temporary process.env.EXPERIMENTAL_RSPACK_INCREMENTAL env var for testing Rspack's new incremental implementation.

Now Rsbuild's e2e tests will run twice, one of which is enabled with incremental.

We will remove it after Rspack incremental is stable.

Related Links

https://rspack.dev/config/experiments#experimentsincremental

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit e4cbf66
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/675be03997140f0008aabff2
😎 Deploy Preview https://deploy-preview-4188--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from ahabhgk December 13, 2024 07:20
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@chenjiahan chenjiahan merged commit 8577d78 into main Dec 13, 2024
10 checks passed
@chenjiahan chenjiahan deleted the incremental_e2e_1213 branch December 13, 2024 07:38
@9aoy 9aoy mentioned this pull request Dec 20, 2024
@chenjiahan chenjiahan mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants