Skip to content

Commit 5ac555b

Browse files
committed
Reduce GetModeCacheKey size
1 parent f037b95 commit 5ac555b

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

crates/rspack_core/src/artifacts/module_graph_cache_artifact.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use indexmap::IndexMap;
88
use rustc_hash::FxHashSet as HashSet;
99
use swc_core::atoms::Atom;
1010

11-
use crate::{DependencyId, ExportInfo, RuntimeSpec};
11+
use crate::{DependencyId, ExportInfo, RuntimeKey};
1212

1313
pub type ModuleGraphCacheArtifact = Arc<ModuleGraphCacheArtifactInner>;
1414

@@ -71,7 +71,7 @@ impl ModuleGraphCacheArtifactInner {
7171
}
7272
}
7373

74-
type GetModeCacheKey = (DependencyId, Option<RuntimeSpec>);
74+
type GetModeCacheKey = (DependencyId, Option<RuntimeKey>);
7575

7676
#[derive(Debug, Default)]
7777
struct GetModeCache {

crates/rspack_plugin_javascript/src/dependency/esm/esm_export_imported_specifier_dependency.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use rspack_cacheable::{
88
use rspack_collections::{IdentifierMap, IdentifierSet};
99
use rspack_core::{
1010
create_exports_object_referenced, create_no_exports_referenced, filter_runtime, get_exports_type,
11-
process_export_info, property_access, property_name, AsContextDependency,
11+
get_runtime_key, process_export_info, property_access, property_name, AsContextDependency,
1212
ConditionalInitFragment, ConnectionState, Dependency, DependencyCategory,
1313
DependencyCodeGeneration, DependencyCondition, DependencyConditionFn, DependencyId,
1414
DependencyLocation, DependencyRange, DependencyTemplate, DependencyTemplateType, DependencyType,
@@ -127,7 +127,10 @@ impl ESMExportImportedSpecifierDependency {
127127
runtime: Option<&RuntimeSpec>,
128128
module_graph_cache: &ModuleGraphCacheArtifact,
129129
) -> ExportMode {
130-
let key = (self.id, runtime.cloned());
130+
let key = (
131+
self.id,
132+
runtime.map(|runtime| get_runtime_key(runtime).to_owned()),
133+
);
131134
module_graph_cache.cached_get_mode(key, || {
132135
self.get_mode_inner(module_graph, module_graph_cache, runtime)
133136
})

0 commit comments

Comments
 (0)