Skip to content

feat: should rename default import based on source #10598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

feat: should rename default import based on source #10598

merged 1 commit into from
Jun 9, 2025

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Jun 6, 2025 •
edited by Timeless0911
Loading

Summary

Before

import external_external_module_default from 'external-module'

This pr

import external_module from 'external-module'

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Jun 6, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 0b62b6b
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/684672721c17520008f6e8e2
😎 Deploy Preview https://deploy-preview-10598--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 6, 2025
Timeless0911
Timeless0911 previously approved these changes Jun 6, 2025
View reviewed changes
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10598 will not alter performance

Comparing feat/remove-external-prefix (0b62b6b) with main (1a3de46)

Summary

✅ 12 untouched benchmarks

@JSerFeng JSerFeng force-pushed the feat/remove-external-prefix branch from 068ccbb to 0b62b6b Compare June 9, 2025 05:34
Timeless0911
Timeless0911 approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JSerFeng JSerFeng merged commit 8015fc7 into main Jun 9, 2025
34 checks passed
@JSerFeng JSerFeng deleted the feat/remove-external-prefix branch June 9, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSerFeng @Timeless0911