Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make url and label mutually exclusive #5088

Open
jgraham opened this issue Nov 9, 2023 · 1 comment
Open

Make url and label mutually exclusive #5088

jgraham opened this issue Nov 9, 2023 · 1 comment

Comments

@jgraham
Copy link
Contributor

jgraham commented Nov 9, 2023

If a links entry has both url and label fields it's unclear exactly what that means: is it just a compression of two separate entries, one with url and one with label, or does it mean that the URL is a link for the label itself in some way?

I think it's supposed to be the former, and therefore for simplicity we should make url and label mutually exclusive.
@foolip
Copy link
Member

foolip commented Nov 9, 2023

@KyleJu can we lint for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgraham @foolip