Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting paths into search box lowercases them, breaking them #3009

Open
gsnedders opened this issue Oct 21, 2022 · 4 comments · May be fixed by #3577
Open

Pasting paths into search box lowercases them, breaking them #3009

gsnedders opened this issue Oct 21, 2022 · 4 comments · May be fixed by #3577

Comments

@gsnedders
Copy link
Member

I was trying to search for shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html or shadow-dom/MouseEvent-prototype-offsetX-offsetY.html, however in both STP 156 and Chrome 109 this gets lowercased and finds nothing.

Oddly, copying the URL gives me the search query before it gets lowercased… and that does manage to find the tests!

@LeonardYam
Copy link
Contributor

Hi @KyleJu, I would like to work on this issue. Just to clarify, we should only need to modify webapp/components/test-search.js right?

@KyleJu
Copy link
Collaborator

KyleJu commented Mar 22, 2023

Hi @KyleJu, I would like to work on this issue. Just to clarify, we should only need to modify webapp/components/test-search.js right?

Yup It is likely a frontend issue and webapp/components/test-search.js should be the place

@LeonardYam
Copy link
Contributor

Hi, I want to check my understanding of the search box.

Right now the search box supports two functions:

  1. Parse a search into the required structured query object using Ohm to pass into the api/search endpoint.
  2. Navigate to a given file-path. E.g. Entering /encoding/encodeInto.any.html should navigate you to the results for that test. (this process is actually automatic and does not require a query commit)

Side-notes:

  • In webapp/components/test-search.js, how does value="{{ queryInput::input }}" work? From my understanding, this is equivalent to having an oninput listener that does this.queryInput = e.target.value and that this is a virtual method call, but I can't find where the input method is binded.
  • For the navigation/auto-complete function, it involves a lot of querySelector calls and code-coupling with webapp/components/wpt-results.js and webapp/components/wpt-app.js. Is there a better way to perform this operation?

gsnedders added a commit to gsnedders/wpt.fyi that referenced this issue Nov 2, 2023
gsnedders added a commit to gsnedders/wpt.fyi that referenced this issue Nov 2, 2023
@foolip
Copy link
Member

foolip commented Nov 13, 2023

I ran into this now when trying to search for "enumerateDevices" tests for web-platform-tests/interop#532. The UI keeps changing it to "enumeratedevices" which doesn't find anything. Editing the URL does work though:
https://wpt.fyi/results/?label=master&label=experimental&aligned&q=%28path%3A%2Faudio-output%20or%20path%3A%2Fmediacapture-streams%29%20enumerateDevices

@KyleJu can you take a look at #3577?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants