[FedCM] Abort when an accounts fetch failed before OnClose

cbiesinger · chromium-wpt-export-bot · commit d82b80f7bf43 · 2025-06-05T11:46:32.000-07:00
If we did get a signin status change and the accounts fetch failed, we should abort the flow in OnClose, to avoid getting stuck with a useless dialog. Bug: 421889736 Change-Id: I330db6257c17804214f0e24e3220680d954d43b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6617245 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Nicolás Peña <npm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1470061}
diff --git a/fedcm/fedcm-login-status/idp-login-with-failed-accounts-fetch.https.html b/fedcm/fedcm-login-status/idp-login-with-failed-accounts-fetch.https.html
@@ -0,0 +1,31 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>FedCM IDP log-in status API tests</title>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
+
+<script type="module">
+import {request_options_with_mediation_required,
+        fedcm_test,
+        fedcm_get_dialog_type_promise,
+        select_manifest,
+        mark_signed_out} from '../support/fedcm-helper.sub.js';
+
+fedcm_test(async t => {
+  await mark_signed_out();
+
+  let test_options = request_options_with_mediation_required("manifest_no_accounts_login_delay.json");
+  await select_manifest(t, test_options);
+
+  test_options.identity.mode = "active";
+  let cred_promise = navigator.credentials.get(test_options);
+
+  // We should get the login popup window, which will automatically set
+  // the login status and close itself.
+  // The promise should get rejected because the accounts list is empty.
+
+  return promise_rejects_dom(t, 'NetworkError', cred_promise);
+}, 'Tests the IDP login dialog and subsequent account chooser.');
+</script>
diff --git a/fedcm/support/login_delay.html b/fedcm/support/login_delay.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<script>
+async function doLogin() {
+  navigator.login.setStatus("logged-in");
+  // Delay the close call to allow the accounts fetch to complete beforehand.
+  setTimeout(() => {
+    IdentityProvider.close();
+  }, 200);
+}
+window.onload = doLogin;
+</script>
diff --git a/fedcm/support/manifest_no_accounts_login_delay.json b/fedcm/support/manifest_no_accounts_login_delay.json
@@ -0,0 +1,6 @@
+{
+  "accounts_endpoint": "no_accounts.py",
+  "client_metadata_endpoint": "client_metadata.py",
+  "id_assertion_endpoint": "token_with_account_id.py",
+  "login_url": "login_delay.html"
+}
diff --git a/lint.ignore b/lint.ignore
@@ -173,6 +173,7 @@ SET TIMEOUT: encrypted-media/polyfill/clearkey-polyfill.js
 SET TIMEOUT: encrypted-media/scripts/playback-temporary-events.js
 SET TIMEOUT: fedcm/support/fedcm-iframe.html
 SET TIMEOUT: fedcm/support/fedcm/disconnect-iframe.html
+SET TIMEOUT: fedcm/support/login_delay.html
 SET TIMEOUT: fetch/fetch-later/resources/fetch-later-helper.js
 SET TIMEOUT: fetch/metadata/resources/helper.sub.js
 SET TIMEOUT: fetch/metadata/resources/message-opener.html
