Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebCodec | AudioEncoder] Test checks for "valid" samplingRate value, when none are defined as invalid #49635

Open
jyavenard opened this issue Dec 11, 2024 · 0 comments

Comments

@jyavenard
Copy link
Contributor

jyavenard commented Dec 11, 2024

comment: 'Sample rate is too small',
config: {
codec: 'opus',
sampleRate: 1,
numberOfChannels: 2,
},
},
{
comment: 'Sample rate is too large',
config: {
codec: 'opus',
sampleRate: 10000000,
numberOfChannels: 2,
},

The test checks that a sampling rate of 1 or 10000000 are invalid, and a whole series of validButUnsupportedConfigs

Why would a configuration be valid but unsupported. It should be normalised and either made it supported or not valid.

Firefox checks that the sampling rate is between 3000 and 384000 inclusive. That seems an acceptable choice

@jyavenard jyavenard changed the title [WebCodec | AudioEncoder] Test checks for "valid" samplingRate value, when none are defined [WebCodec | AudioEncoder] Test checks for "valid" samplingRate value, when none are defined as invalid Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants