-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ WebCodecs | AudioDecoder ] Test wants both the same configuration to be invalid and not supported: it can only be one or the other. #49636
Labels
Comments
jyavenard
added a commit
to jyavenard/WebKit
that referenced
this issue
Dec 11, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by NOBODY (OOPS!). Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig):
jyavenard
added a commit
to jyavenard/WebKit
that referenced
this issue
Dec 11, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by NOBODY (OOPS!). Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig):
jyavenard
added a commit
to jyavenard/WebKit
that referenced
this issue
Dec 11, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by NOBODY (OOPS!). Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig):
jyavenard
added a commit
to jyavenard/WebKit
that referenced
this issue
Dec 13, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by NOBODY (OOPS!). Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig):
jyavenard
added a commit
to jyavenard/WebKit
that referenced
this issue
Dec 13, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by NOBODY (OOPS!). Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig):
jyavenard
added a commit
to jyavenard/WebKit
that referenced
this issue
Dec 13, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by NOBODY (OOPS!). Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig):
jyavenard
added a commit
to jyavenard/WebKit
that referenced
this issue
Dec 13, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by NOBODY (OOPS!). Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig):
jyavenard
added a commit
to jyavenard/WebKit
that referenced
this issue
Dec 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by NOBODY (OOPS!). Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig):
webkit-commit-queue
pushed a commit
to jyavenard/WebKit
that referenced
this issue
Dec 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by Jer Noble. Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig): Canonical link: https://commits.webkit.org/287852@main
Jarred-Sumner
pushed a commit
to oven-sh/WebKit
that referenced
this issue
Dec 18, 2024
https://bugs.webkit.org/show_bug.cgi?id=283900 rdar://140781718 Reviewed by Jer Noble. Upstream commit: web-platform-tests/wpt@76dfa54 Make modifications to our code to pass some new tests that caused failures. All of them are about non-normalised changes with non-specified specification. Corresponding WPT or spec bugs were opened as mentioned in the related code comments. We have two failures marked as expected as they are clearly not spec compliant web-platform-tests/wpt#49636 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/README.md: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.js: (createDefaultAudioData): (pow2): (isInteger): (epsilon): (get_type_values): (typeToArrayType): (arrayTypeToType): (check_array_equality): (conversionTest): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js: (description.new.Uint8Array): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.js: (pcm): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_f32-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_vorbis-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_flac-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_f32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s16-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s24-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_s32-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_u8-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_ulaw-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_vorbis-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.js: (async idlArray): * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-f32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s16.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s24.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-s32.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-pcm-u8.wav: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-ulaw.wav: Renamed from LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-mulaw.wav. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx-vorbis.ogg: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/sfx.flac: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::isSupportedEncoderCodec): (WebCore::isValidEncoderConfig): Canonical link: https://commits.webkit.org/287852@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
wpt/webcodecs/audio-decoder.https.any.js
Lines 55 to 60 in 1f7679a
It checks that a configuration using Opus with more than 2 channels and no description be considered invalid.
But in:
wpt/webcodecs/audio-decoder.https.any.js
Lines 152 to 165 in 1f7679a
It checks that a configuration using Opus with more than 2 channels and no description is not supported.
It can't be both.
Per spec https://w3c.github.io/webcodecs/#dom-audiodecoder-configure
"If config is not a valid AudioDecoderConfig, throw a TypeError."
So if we want a configuration using Opus with more than 2 channels and no description be considered as invalid, then
configure
must throw with a TypeError when given that same configuration.
In the same line of thought,it would probably make sense to also check the Opus' description is greater than 10 bytes and make it be invalid otherwise.
The text was updated successfully, but these errors were encountered: