You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
wptrunner.wpttest.RunInfo is used all over the place, but it currently assumes that it is either being run on the machine the info is being gathered for or that it knows how to override what it finds for the current machine. This seems silly, because this means wpttest needs to knowledge of how to introspect anything a Browser might be running on.
With the amount of logic in here, it feels like it should at least be wptrunner.product.Product.get_run_info if not wptrunner.browsers.base.Browser.get_run_info — though the latter is practically impossible given we need to know the run_info to load tests correctly, which we do before we create any Browser.
Adding support for iOS would result in even more logic living in wpttest, which feels even further wrong.
I think the type, ignoring any RunInfoExtras, is crudely (note this is invalid, mozinfo doesn't actually export type(mozinfo.unknown)` anywhere so we can't actually match it):
wptrunner.wpttest.RunInfo
is used all over the place, but it currently assumes that it is either being run on the machine the info is being gathered for or that it knows how to override what it finds for the current machine. This seems silly, because this meanswpttest
needs to knowledge of how to introspect anything aBrowser
might be running on.With the amount of logic in here, it feels like it should at least be
wptrunner.product.Product.get_run_info
if notwptrunner.browsers.base.Browser.get_run_info
— though the latter is practically impossible given we need to know therun_info
to load tests correctly, which we do before we create anyBrowser
.Adding support for iOS would result in even more logic living in
wpttest
, which feels even further wrong.I think the type, ignoring any RunInfoExtras, is crudely (note this is invalid,
mozinfo
doesn't actually export type(mozinfo.unknown)` anywhere so we can't actually match it):The text was updated successfully, but these errors were encountered: