refactor: refactor commit-info API and GitHub history inconsistency

Signed-off-by: allure <[email protected]>

Author: AllureCurtain

ceres/src/api_service/commit_ops.rs

@@ -2,24 +2,59 @@ use std::{path::PathBuf, sync::Arc};
 
 use git_internal::{
     errors::GitError,
-    hash::SHA1,
-    internal::object::{
-        commit::Commit,
-        tree::{TreeItem, TreeItemMode},
-    },
+    internal::object::tree::{TreeItem, TreeItemMode},
 };
 use tokio::sync::Mutex;
 
 use crate::api_service::{ApiHandler, cache::GitObjectCache, history, tree_ops};
 use crate::model::git::{CommitBindingInfo, LatestCommitInfo};
 
+/// Get the latest commit that modified a file or directory.
+///
+/// This unified function handles both tag-based and commit-based browsing through
+/// the `refs` parameter, ensuring consistent behavior across all code paths.
+///
+/// # Arguments
+/// - `handler`: API handler for accessing Git data
+/// - `path`: File or directory path to check
+/// - `refs`: Optional reference (tag name or commit SHA). If None, uses default HEAD/root.
+///
+/// # Returns
+/// The commit information for the last modification of the specified path.
 pub async fn get_latest_commit<T: ApiHandler + ?Sized>(
     handler: &T,
     path: PathBuf,
+    refs: Option<&str>,
 ) -> Result<LatestCommitInfo, GitError> {
+    // Resolve the starting commit from refs
+    let start_commit = crate::api_service::resolve_start_commit(handler, refs).await?;
+
     // 1) Try as directory path first
-    if let Some(tree) = tree_ops::search_tree_by_path(handler, &path, None).await? {
-        let commit = get_tree_relate_commit(handler, tree.id, path).await?;
+    if let Some(tree) = tree_ops::search_tree_by_path(handler, &path, refs).await? {
+        // Treat directory as a TreeItem and find its last modification
+        let dir_name = path
+            .file_name()
+            .and_then(|n| n.to_str())
+            .ok_or_else(|| GitError::CustomError("Invalid directory path".to_string()))?
+            .to_string();
+
+        let parent = path
+            .parent()
+            .ok_or_else(|| GitError::CustomError("Directory has no parent".to_string()))?;
+
+        let dir_item = TreeItem::new(TreeItemMode::Tree, tree.id, dir_name);
+
+        let cache = Arc::new(Mutex::new(GitObjectCache::default()));
+
+        let commit = history::traverse_commit_history_for_last_modification(
+            handler,
+            parent,
+            start_commit.clone(),
+            &dir_item,
+            cache,
+        )
+        .await?;
+
         let mut commit_info: LatestCommitInfo = commit.clone().into();
 
         // If commit has a username binding, prefer showing that username
@@ -38,25 +73,11 @@ pub async fn get_latest_commit<T: ApiHandler + ?Sized>(
     }
 
     // 2) If not a directory, try as file path
-    // basic validation for file path
-    path.file_name()
-        .and_then(|n| n.to_str())
-        .ok_or_else(|| GitError::CustomError("Invalid file path".to_string()))?;
-    let parent = path
-        .parent()
-        .ok_or_else(|| GitError::CustomError("Invalid file path".to_string()))?;
+    // Use unified last-modification logic
+    let cache = Arc::new(Mutex::new(GitObjectCache::default()));
 
-    // parent must be a directory tree that exists
-    if tree_ops::search_tree_by_path(handler, parent, None)
-        .await?
-        .is_none()
-    {
-        return Err(GitError::CustomError(
-            "can't find target parent tree under latest commit".to_string(),
-        ));
-    };
-    match history::resolve_latest_commit_for_file_path(handler, &path).await? {
-        Some(commit) => {
+    match history::resolve_last_modification_by_path(handler, &path, start_commit, cache).await {
+        Ok(commit) => {
             let mut commit_info: LatestCommitInfo = commit.clone().into();
             // If commit has a username binding, prefer showing that username
             if let Ok(Some(binding)) = handler
@@ -71,35 +92,12 @@ pub async fn get_latest_commit<T: ApiHandler + ?Sized>(
             }
             Ok(commit_info)
         }
-        None => Err(GitError::CustomError(
+        Err(_) => Err(GitError::CustomError(
             "[code:404] File not found".to_string(),
         )),
     }
 }
 
-pub async fn get_tree_relate_commit<T: ApiHandler + ?Sized>(
-    handler: &T,
-    t_hash: SHA1,
-    path: PathBuf,
-) -> Result<Commit, GitError> {
-    let file_name = match path.file_name() {
-        Some(name) => name.to_string_lossy().to_string(),
-        None => {
-            return Err(GitError::CustomError("Invalid Path Input".to_string()));
-        }
-    };
-
-    let search_item = TreeItem::new(TreeItemMode::Tree, t_hash, file_name);
-    let cache = Arc::new(Mutex::new(GitObjectCache::default()));
-    let root_commit = Arc::new(handler.get_root_commit().await);
-
-    let parent = match path.parent() {
-        Some(p) => p,
-        None => return Err(GitError::CustomError("Invalid Path Input".to_string())),
-    };
-    history::traverse_commit_history(handler, parent, root_commit, &search_item, cache).await
-}
-
 /// Build commit binding information for a given commit SHA
 pub async fn build_commit_binding_info<T: ApiHandler + ?Sized>(
     handler: &T,